Created attachment 70481 [details] screenshot de-DE Bug 19413 moved the buttons in the cataloguing plugins to the top, this doesn't work well for translations where the terms 'cancel' and 'ok' can be longer.
Created attachment 75707 [details] [review] Bug 19970: Revise change of bug 19413 to work better for translations This patch changes how the submit and cancel buttons appear in the MARC 008 plugin window. The controls are now displayed as buttons in a floating toolbar. To test you must have MARC tag 008 configured to use the marc21_field_008.pl plugin. - Apply the patch and open an existing or blank record in cataloging. - Click the plugin link next to tag 008 to trigger the popup window. - Confirm that "Save" and "Cancel" appear correctly in a toolbar. - Scroll down the page to confirm that the toolbar "sticks" to the top of the window. - Confirm that the "Save" and "Cancel" buttons work correctly.
Created attachment 75935 [details] [review] Bug 19970: Revise change of bug 19413 to work better for translations This patch changes how the submit and cancel buttons appear in the MARC 008 plugin window. The controls are now displayed as buttons in a floating toolbar. To test you must have MARC tag 008 configured to use the marc21_field_008.pl plugin. - Apply the patch and open an existing or blank record in cataloging. - Click the plugin link next to tag 008 to trigger the popup window. - Confirm that "Save" and "Cancel" appear correctly in a toolbar. - Scroll down the page to confirm that the toolbar "sticks" to the top of the window. - Confirm that the "Save" and "Cancel" buttons work correctly. Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> Followed the test plan and the patch works.
Created attachment 76070 [details] [review] Bug 19970: Revise change of bug 19413 to work better for translations This patch changes how the submit and cancel buttons appear in the MARC 008 plugin window. The controls are now displayed as buttons in a floating toolbar. To test you must have MARC tag 008 configured to use the marc21_field_008.pl plugin. - Apply the patch and open an existing or blank record in cataloging. - Click the plugin link next to tag 008 to trigger the popup window. - Confirm that "Save" and "Cancel" appear correctly in a toolbar. - Scroll down the page to confirm that the toolbar "sticks" to the top of the window. - Confirm that the "Save" and "Cancel" buttons work correctly. Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> Followed the test plan and the patch works. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
I guess it would be useful to have the result floating as well (?)
Awesome work all! Pushed to master for 18.11
Pushed to 18.05.x for 18.05.01
Hi, I'm not sure how to apply on 17.11.x since it does not have Asset TT plugin (Bug 20538). Can you provide a rebased patch ?
Created attachment 76118 [details] [review] Bug 19970: (17.05.x) Revise change of bug 19413 to work better for translations This patch changes how the submit and cancel buttons appear in the MARC 008 plugin window. The controls are now displayed as buttons in a floating toolbar. To test you must have MARC tag 008 configured to use the marc21_field_008.pl plugin. - Apply the patch and open an existing or blank record in cataloging. - Click the plugin link next to tag 008 to trigger the popup window. - Confirm that "Save" and "Cancel" appear correctly in a toolbar. - Scroll down the page to confirm that the toolbar "sticks" to the top of the window. - Confirm that the "Save" and "Cancel" buttons work correctly.
Created attachment 76119 [details] [review] Bug 19970: (17.11.x) Revise change of bug 19413 to work better for translations This patch changes how the submit and cancel buttons appear in the MARC 008 plugin window. The controls are now displayed as buttons in a floating toolbar. To test you must have MARC tag 008 configured to use the marc21_field_008.pl plugin. - Apply the patch and open an existing or blank record in cataloging. - Click the plugin link next to tag 008 to trigger the popup window. - Confirm that "Save" and "Cancel" appear correctly in a toolbar. - Scroll down the page to confirm that the toolbar "sticks" to the top of the window. - Confirm that the "Save" and "Cancel" buttons work correctly.
Pushed to 17.11.x for 17.11.07