Created attachment 70550 [details] [review] Bug 19979: Fix get_facets_info test in Search.t The test should remove the holdingbranch key in the expected results when there is only one branch. See the logic in C4::Koha. Test plan: [1] Run Search.t on a database with multiple branches. [2] Run Search.t on a database with one branch. Without this patch the test would fail: Failed test '_get_facets_info returns the correct data'. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Created attachment 72266 [details] [review] Bug 19979: Fix get_facets_info test in Search.t The test should remove the holdingbranch key in the expected results when there is only one branch. See the logic in C4::Koha. Test plan: [1] Run Search.t on a database with multiple branches. [2] Run Search.t on a database with one branch. Without this patch the test would fail: Failed test '_get_facets_info returns the correct data'. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 72267 [details] [review] Bug 19979: ->count and be called directly on Koha::Objects Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Trivial, skipping QA.
Pushed to master for 18.05, thanks to everybody involved!
Awesome work all! Pushed to stable for 17.11.04
Pushed to 17.05.x for v17.05.10