Set a default circ rule vagrant@kohadevbox:kohaclone(BUGFUN)$ prove t/db_dependent/TestBuilder.t t/db_dependent/TestBuilder.t .. 1/13 Violation of unique constraint in DefaultCircRule at /home/vagrant/kohaclone/t/lib/TestBuilder.pm line 241. # Failed test 'TestBuilder should be able to create an object for every source' # at t/db_dependent/TestBuilder.t line 78. # got: '1' # expected: '0' # The following sources have not been generated correctly: DefaultCircRule # Looks like you failed 1 test of 1. t/db_dependent/TestBuilder.t .. 3/13 # Failed test 'Build all sources' # at t/db_dependent/TestBuilder.t line 84. t/db_dependent/TestBuilder.t .. 12/13 # Looks like you failed 1 test of 13. t/db_dependent/TestBuilder.t .. Dubious, test returned 1 (wstat 256, 0x100) Failed 1/13 subtests
Created attachment 70812 [details] [review] Bug 19985: Make TestBuilder.t pass even if default_circ_rules is not empty This table cannot contain more than 1 row, so we need to remove its data before trying to generate a new entry. Test plan: Set a default circ rule prove t/db_dependent/TestBuilder.t should return green Without this patch you get: # Failed test 'TestBuilder should be able to create an object for every source' # at t/db_dependent/TestBuilder.t line 78. # got: '1' # expected: '0' # The following sources have not been generated correctly: DefaultCircRule # Looks like you failed 1 test of 1.
Created attachment 70817 [details] [review] Bug 19985: Make TestBuilder.t pass even if default_circ_rules is not empty This table cannot contain more than 1 row, so we need to remove its data before trying to generate a new entry. Test plan: Set a default circ rule prove t/db_dependent/TestBuilder.t should return green Without this patch you get: # Failed test 'TestBuilder should be able to create an object for every source' # at t/db_dependent/TestBuilder.t line 78. # got: '1' # expected: '0' # The following sources have not been generated correctly: DefaultCircRule # Looks like you failed 1 test of 1. Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Trivial, skipping QA.
(In reply to Jonathan Druart from comment #3) > Trivial, skipping QA. Please adjust status if you do so. This has been pushed while still in the signoff queue. Thanks.
Awesome work all! Pushed to stable for 17.11.03
Pushed to 17.05.x for v17.05.09