The server name field is a required field, but it is not red and does not say required like the other required fields. To reproduce: 1) Go to Admin -> z39.50/SRU servers 2) Make a new z39.50 server 3) Fill in the required fields (hostname, port, database) 4) Save the server 5) Notice the form does not submit, tells you that server name is required. The behaviour is the same for making a new SRU server too, so also needs to be fixed there.
Created attachment 70646 [details] [review] Bug 19986: 'Server name' doesn't appear as required Test plan: [1.] Go to Admin -> z39.50/SRU servers [2.] Make a new z39.50 server [3.] Fill in the required field (hostname, port, database) [4.] Save the server [5.] Notice that the form does not submit, tells you that Sever name is required [6.] Repeat steps 2 - 5 but this time make a new SRU server [6.] Upload the patch and repeat steps 1 - 3 (make a new z39.50 server and a new SRRU server) [7.] See that now 'Server name:' is red and on the right side of the box there is a required note [8.] Save both servers and it should have created a new z39.50 server and a new SRU server https://bugs.koha-community.org/show_bug.cgi?id=19833
(In reply to Grace from comment #1) > Created attachment 70646 [details] [review] [review] > Bug 19986: 'Server name' doesn't appear as required > > Test plan: > [1.] Go to Admin -> z39.50/SRU servers > [2.] Make a new z39.50 server > [3.] Fill in the required field (hostname, port, database) > [4.] Save the server > [5.] Notice that the form does not submit, tells you that Sever name is > required > [6.] Repeat steps 2 - 5 but this time make a new SRU server > [6.] Upload the patch and repeat steps 1 - 3 (make a new z39.50 server > and a new SRRU server) > [7.] See that now 'Server name:' is red and on the right side of the box > there is a required note > [8.] Save both servers and it should have created a new z39.50 server > and a new SRU server > > https://bugs.koha-community.org/show_bug.cgi?id=19833 P.S the link was added by accident and is not relevant to this bug :)
Created attachment 70985 [details] [review] Bug 19986: 'Server name' doesn't appear as required Test plan: [1.] Go to Admin -> z39.50/SRU servers [2.] Make a new z39.50 server [3.] Fill in the required field (hostname, port, database) [4.] Save the server [5.] Notice that the form does not submit, tells you that Sever name is required [6.] Repeat steps 2 - 5 but this time make a new SRU server [6.] Upload the patch and repeat steps 1 - 3 (make a new z39.50 server and a new SRRU server) [7.] See that now 'Server name:' is red and on the right side of the box there is a required note [8.] Save both servers and it should have created a new z39.50 server and a new SRU server https://bugs.koha-community.org/show_bug.cgi?id=19833 Signed-off-by: Roch D'Amour <roch.damour@inlibro.com>
Created attachment 71026 [details] [review] Bug 19986: 'Server name' doesn't appear as required Test plan: [1.] Go to Admin -> z39.50/SRU servers [2.] Make a new z39.50 server [3.] Fill in the required field (hostname, port, database) [4.] Save the server [5.] Notice that the form does not submit, tells you that Sever name is required [6.] Repeat steps 2 - 5 but this time make a new SRU server [6.] Upload the patch and repeat steps 1 - 3 (make a new z39.50 server and a new SRRU server) [7.] See that now 'Server name:' is red and on the right side of the box there is a required note [8.] Save both servers and it should have created a new z39.50 server and a new SRU server Signed-off-by: Roch D'Amour <roch.damour@inlibro.com> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Pushed to master for 18.05, thanks to everybody involved!
Awesome work all! This patch has been pushed to 17.11.x and will be in 17.11.03