This patch will convert several unrelated templates to use the Bootstrap grid: - about.tt - auth.tt - serials/subscription-add.tt - admin/admin-home.tt - reports/reports-home.tt - suggestion/suggestion.tt
Created attachment 70760 [details] [review] Bug 20045: Switch single-column templates to Bootstrap grid: Various This patch updates various unrelated templates to use the Bootstrap grid. - about.tt - The about page - auth.tt - The login page These pages should look correct. - reports/reports-home.tt - The reports home page - admin/admin-home.tt - The administration home page These pages should look correct, with a single centered column with wide margins on either side. At lower browser widths the margins should disappear. - serials/subscription-add.tt - Serials -> Add subscription. The entry form should look correct during each step of the add/edit process. - suggestion/suggestion.tt - Acquisitions -> Suggestions -> New suggestion. The page with the new suggestion form should look correct.
On sugestions/suggestions and serials/subscription-add the labels for input fields have been squashed together meaning the longer ones can be up to 5 lines with one or two words per line. Would be nice if we could balance these out a little more. Everything else looks good!
Created attachment 72509 [details] [review] Bug 20045: Switch single-column templates to Bootstrap grid: Various This patch updates various unrelated templates to use the Bootstrap grid. - about.tt - The about page - auth.tt - The login page These pages should look correct. - reports/reports-home.tt - The reports home page - admin/admin-home.tt - The administration home page These pages should look correct, with a single centered column with wide margins on either side. At lower browser widths the margins should disappear. - serials/subscription-add.tt - Serials -> Add subscription. The entry form should look correct during each step of the add/edit process. - suggestion/suggestion.tt - Acquisitions -> Suggestions -> New suggestion. The page with the new suggestion form should look correct.
Created attachment 72621 [details] [review] Bug 20045: Switch single-column templates to Bootstrap grid: Various This patch updates various unrelated templates to use the Bootstrap grid. - about.tt - The about page - auth.tt - The login page These pages should look correct. - reports/reports-home.tt - The reports home page - admin/admin-home.tt - The administration home page These pages should look correct, with a single centered column with wide margins on either side. At lower browser widths the margins should disappear. - serials/subscription-add.tt - Serials -> Add subscription. The entry form should look correct during each step of the add/edit process. - suggestion/suggestion.tt - Acquisitions -> Suggestions -> New suggestion. The page with the new suggestion form should look correct. Signed-off-by: Roch D'Amour <roch.damour@inlibro.com>
Created attachment 73240 [details] [review] Bug 20045: Switch single-column templates to Bootstrap grid: Various This patch updates various unrelated templates to use the Bootstrap grid. - about.tt - The about page - auth.tt - The login page These pages should look correct. - reports/reports-home.tt - The reports home page - admin/admin-home.tt - The administration home page These pages should look correct, with a single centered column with wide margins on either side. At lower browser widths the margins should disappear. - serials/subscription-add.tt - Serials -> Add subscription. The entry form should look correct during each step of the add/edit process. - suggestion/suggestion.tt - Acquisitions -> Suggestions -> New suggestion. The page with the new suggestion form should look correct. Signed-off-by: Roch D'Amour <roch.damour@inlibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to master for 18.05, thanks to everybody involved!
Created attachment 73320 [details] [review] Bug 20045: Fix Selenium tests Element id=doc does not longer exist on the admin home page The "main block" need to be localized using the new class 'main container-fluid' We will certainly need to improve this later.
Last patch pushed to master.