Created attachment 70756 [details] [review] Bug 20047 - Add Koha::Z3950Server Oject and use it to get server count To test: 1 - prove t/db_dependent/Koha/Z3950Servers.t 2 - Load cataloging and authority home pages 3 - Verify you can add form z395 on each page 4 - Delete all z3950 servers 5 - Verify option to add from Z3950 is removed on both pages
The QA tool has a couple of complaints about this patch: FAIL Koha/Z3950Server.pm OK critic OK forbidden patterns OK git manipulation OK pod FAIL pod coverage POD coverage was greater before, try perl -MPod::Coverage=PackageName -e666 OK spelling OK valid FAIL Koha/Z3950Servers.pm OK critic OK forbidden patterns OK git manipulation OK pod FAIL pod coverage POD is missing for 'object_class' OK spelling OK valid
Created attachment 70829 [details] [review] Bug 20047 - Add Koha::Z3950Server Oject and use it to get server count To test: 1 - prove t/db_dependent/Koha/Z3950Servers.t 2 - Load cataloging and authority home pages 3 - Verify you can add form z395 on each page 4 - Delete all z3950 servers 5 - Viery option to add from Z3950 is removed on both pages
(In reply to Owen Leonard from comment #2) > The QA tool has a couple of complaints about this patch: It still does, but ignore them, they are not relevant
Created attachment 72681 [details] [review] Bug 20047 - Add Koha::Z3950Server Oject and use it to get server count To test: 1 - prove t/db_dependent/Koha/Z3950Servers.t 2 - Load cataloging and authority home pages 3 - Verify you can add form z395 on each page 4 - Delete all z3950 servers 5 - Viery option to add from Z3950 is removed on both pages Signed-off-by: Jesse Maseto <jesse@bywatersolutions.com>
Please rebase!
Created attachment 74316 [details] [review] Bug 20047 - Add Koha::Z3950Server Oject and use it to get server count To test: 1 - prove t/db_dependent/Koha/Z3950Servers.t 2 - Load cataloging and authority home pages 3 - Verify you can add form z395 on each page 4 - Delete all z3950 servers 5 - Viery option to add from Z3950 is removed on both pages Signed-off-by: Jesse Maseto <jesse@bywatersolutions.com>
Created attachment 74317 [details] [review] Bug 20047: (follow-up) Retrieve only biblio/authority servers as appropriate
Created attachment 74405 [details] [review] Bug 20047: Add Koha::Z3950Server Oject and use it to get server count To test: 1 - prove t/db_dependent/Koha/Z3950Servers.t 2 - Load cataloging and authority home pages 3 - Verify you can add form z395 on each page 4 - Delete all z3950 servers 5 - Viery option to add from Z3950 is removed on both pages Signed-off-by: Jesse Maseto <jesse@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 74406 [details] [review] Bug 20047: (follow-up) Retrieve only biblio/authority servers as appropriate Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to master for 18.05, thanks to everybody involved!