There's two untranslatable strings in OAI set config: "setDescription" and "Remove"
Created attachment 71245 [details] [review] Bug 20140: Allow translating more of OAI sets Allow translating two strings in the OAI set config: "setDescription" and "Remove" Test plan: 1) Go to Home -> Administrator -> OAI sets config -> Add a new OAI set 2) Click on "New set" 3) Click on "Add description" 4) Note the "setDescription:" and "Remove" -texts 5) Install patch, update language, translate the new strings 6) Redo 1-4, note how the strings in part 4 are now translated
Created attachment 72161 [details] [review] Bug 20140: Allow translating more of OAI sets Allow translating two strings in the OAI set config: "setDescription" and "Remove" Test plan: 1) Go to Home -> Administrator -> OAI sets config -> Add a new OAI set 2) Click on "New set" 3) Click on "Add description" 4) Note the "setDescription:" and "Remove" -texts 5) Install patch, update language, translate the new strings 6) Redo 1-4, note how the strings in part 4 are now translated Signed-off-by: Pasi Kallinen <pasi.kallinen@joensuu.fi> Signed-off-by: Roch D'Amour <roch.damour@inlibro.com>
Hi Paxed, patch is fine as usual, but wondering about setDescription. I think the term was taken from the OAI spec: https://www.openarchives.org/OAI/openarchivesprotocol.html a setDescription -- an optional and repeatable container that may hold community-specific XML-encoded data about the set; the accompanying Implementation Guidelines document provides suggestions regarding the usage of this container. So maybe we want to change it in English too? "Description (setDescription):" ?
(In reply to Katrin Fischer from comment #3) > Hi Paxed, patch is fine as usual, but wondering about setDescription. I > think the term was taken from the OAI spec: > > https://www.openarchives.org/OAI/openarchivesprotocol.html > a setDescription -- an optional and repeatable container that may hold > community-specific XML-encoded data about the set; the accompanying > Implementation Guidelines document provides suggestions regarding the usage > of this container. > > So maybe we want to change it in English too? "Description > (setDescription):" ? Perhaps, but there were two reasons for why I made it translatable: 1) The same "setDescription" text header in the table, and the same label above in the template are translatable - so why not this instance of it? 2) Leaving a text string in javascript like that is a bad example - perhaps someone will look at it and add similar untranslatable strings elsewhere. Better have everything translatable that sometimes some strings not.
Created attachment 72195 [details] [review] Bug 20140: Allow translating more of OAI sets Allow translating two strings in the OAI set config: "setDescription" and "Remove" Test plan: 1) Go to Home -> Administrator -> OAI sets config -> Add a new OAI set 2) Click on "New set" 3) Click on "Add description" 4) Note the "setDescription:" and "Remove" -texts 5) Install patch, update language, translate the new strings 6) Redo 1-4, note how the strings in part 4 are now translated Signed-off-by: Pasi Kallinen <pasi.kallinen@joensuu.fi> Signed-off-by: Roch D'Amour <roch.damour@inlibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to master for 18.05, thanks to everybody involved!
Awesome work all, backported to stable for 17.11.05