The language menu in the OPAC's header has light blue links which aren't very readable because of their low contrast. This menu should be styled to match the Lists menu.
Created attachment 71294 [details] [review] Bug 20155 - Improve readability of OPAC header language menu This patch makes some minor HTML and CSS changes in order to make the header's language-chooser menu more readable and consistent with the Lists menu. To test, apply this patch and the patch with the compiled CSS. - Install and enable more than one translation. - Set the OpacLangSelectorMode to either "top" or "both top and footer." - View the OPAC's header menu and confirm that the links and menus look correct whether or not a user is logged in.
Created attachment 71295 [details] [review] Bug 20155 (Follow-up) Compiled CSS This patch contains the compiled opac.css file.
Created attachment 71299 [details] [review] [SIGNED-OFF] Bug 20155 - Improve readability of OPAC header language menu This patch makes some minor HTML and CSS changes in order to make the header's language-chooser menu more readable and consistent with the Lists menu. To test, apply this patch and the patch with the compiled CSS. - Install and enable more than one translation. - Set the OpacLangSelectorMode to either "top" or "both top and footer." - View the OPAC's header menu and confirm that the links and menus look correct whether or not a user is logged in. Signed-off-by: Jon Knight <J.P.Knight@lboro.ac.uk>
Created attachment 71300 [details] [review] [SIGNED-OFF] Bug 20155 (Follow-up) Compiled CSS This patch contains the compiled opac.css file. Signed-off-by: Jon Knight <J.P.Knight@lboro.ac.uk>
Hi Owen, great patches as usual :) Fixed the bug descriptions a bit to fit the new guidelines.
Created attachment 71330 [details] [review] Bug 20155: Improve readability of OPAC header language menu This patch makes some minor HTML and CSS changes in order to make the header's language-chooser menu more readable and consistent with the Lists menu. To test, apply this patch and the patch with the compiled CSS. - Install and enable more than one translation. - Set the OpacLangSelectorMode to either "top" or "both top and footer." - View the OPAC's header menu and confirm that the links and menus look correct whether or not a user is logged in. Signed-off-by: Jon Knight <J.P.Knight@lboro.ac.uk> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 71331 [details] [review] Bug 20155: (follow-up) Compiled CSS This patch contains the compiled opac.css file. Signed-off-by: Jon Knight <J.P.Knight@lboro.ac.uk> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to master for 18.05, thanks to everybody involved!
Awesome work all! Enhancement, not backported to stable.