The markup for the staff client header's language menu is supposed to show a check mark next to the currently-selected language. Because of copy-paste from the OPAC (which uses Glyphicons), the check mark doesn't appear. It should use Font Awesome.
Created attachment 71297 [details] [review] Bug 20156 - Staff client header language menu doesn't show check mark for current language This patch replaces Glyphicon markup with Font Awesome markup so that a check mark appears next to the currently-selected language in the staff client header's language menu. Also changed in this patch: Some classes have been removed because they are not used in staff client CSS. To test you must have multiple languages installed and enabled in the staff client. - Set the StaffLangSelectorMode system preference to "top" or "both top and footer" - Confirm that the currently-select language in the langauge menu has a check mark next to it.
Created attachment 71298 [details] [review] Bug 20156 - Staff client header language menu doesn't show check mark for current language This patch replaces Glyphicon markup with Font Awesome markup so that a check mark appears next to the currently-selected language in the staff client header's language menu. Also changed in this patch: Some classes have been removed because they are not used in staff client CSS. To test you must have multiple languages installed and enabled in the staff client. - Set the StaffLangSelectorMode system preference to "top" or "both top and footer" - Confirm that the currently-select language in the langauge menu has a check mark next to it. Signed-off-by: Jon Knight <J.P.Knight@lboro.ac.uk>
Created attachment 71329 [details] [review] Bug 20156 - Staff client header language menu doesn't show check mark for current language This patch replaces Glyphicon markup with Font Awesome markup so that a check mark appears next to the currently-selected language in the staff client header's language menu. Also changed in this patch: Some classes have been removed because they are not used in staff client CSS. To test you must have multiple languages installed and enabled in the staff client. - Set the StaffLangSelectorMode system preference to "top" or "both top and footer" - Confirm that the currently-select language in the langauge menu has a check mark next to it. Signed-off-by: Jon Knight <J.P.Knight@lboro.ac.uk> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to master for 18.05, thanks to everybody involved!
Awesome work all, pushed to stable for 17.11.03