The search options for patron search include "Street Address". This should be fixed to be "Street address" instead to follow our capitalization rules. To test: - Go to "Patrons" - Switch in top search to tab "Search patrons" - Click on + sign - Check "Search fields" pull down - Compare to same pull down in the filters at the right side -> top search option is spelled wrong, the one on the right is correct
Created attachment 83929 [details] [review] Bug 20165 : Changed uppercase letter to a lowercase letter in the patron search search fields under the plus option. Changed "Street Address" to "Street address" in the patron search search fields under the plus sign to fit Koha's capitalization rules. To find this change: 1. Go to Patrons and switch in the search to search patrons 2. Click on the plus sign 3. Check "Search fields" pull down 4. "Street Address" should now be "Street address"
Hi Olivia. I couldn't get your patch to work. I think line 53 needs to be changed as well: 53 <option value='address'>Street Address</option> David Nind
Created attachment 84012 [details] [review] Bug 20165 : Changed uppercase letter to a lowercase letter in the patron search search fields under the plus option. Changed "Street Address" to "Street address" in the patron search search fields under the plus sign to fit Koha's capitalization rules. To find this change: 1. Go to Patrons and switch in the search to search patrons 2. Click on the plus sign 3. Check "Search fields" pull down 4. "Street Address" should now be "Street address"
Hi Olivia, can you take another look? I think you uploaded the same patch again, It shows the "Street Address" remaining a few lines below your change.
Created attachment 84025 [details] [review] Bug 20165: Changed uppercase letter to a lowercase letter in the patron search search fields under the plus option. Changed "Street Address" to "Street address" in the patron search search fields under the plus sign to fit Koha's capitalization rules. To find this change: 1. Go to Patrons and switch in the search to search patrons 2. Click on the plus sign 3. Check "Search fields" pull down 4. "Street Address" should now be "Street address"
Created attachment 84029 [details] [review] Bug 20165: Changed uppercase letter to a lowercase letter in the patron search search fields under the plus option. Changed "Street Address" to "Street address" in the patron search search fields under the plus sign to fit Koha's capitalization rules. To find this change: 1. Go to Patrons and switch in the search to search patrons 2. Click on the plus sign 3. Check "Search fields" pull down 4. "Street Address" should now be "Street address" Signed-off-by: David Nind <david@davidnind.com>
Nice work Olivia!
Created attachment 84078 [details] [review] Bug 20165: Changed uppercase letter to a lowercase letter in the patron search search fields under the plus option. Changed "Street Address" to "Street address" in the patron search search fields under the plus sign to fit Koha's capitalization rules. To find this change: 1. Go to Patrons and switch in the search to search patrons 2. Click on the plus sign 3. Check "Search fields" pull down 4. "Street Address" should now be "Street address" Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Awesome work Olivia! Pushed to master for 19.05
Pushed to 18.11.x for 18.11.03
Pushed to 18.05.x for 18.05.09
I dont push to 17.11.x to minimize translation work