DBD::mysql::st execute failed: Incorrect date value: '2018-02-14 02:03 PM' for column 'entrydate' at row 1 [for Statement "INSERT INTO `aqorders` ( `basketno`, `biblionumber`, `budget_id`, `entrydate`, `ordernum ber`, `quantity`, `quantityreceived`) VALUES ( ?, ?, ?, ?, ?, ?, ? )" with ParamValues: 0='14', 1='454', 2='13', 3='2018-02-14 02:03 PM', 4=undef, 5=1, 6=0] at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 183 2.
Created attachment 71623 [details] [review] Bug 20199: Add tests for Koha::Acq::Order->store
Created attachment 71624 [details] [review] Bug 20199: Send a DateTime to DBIC instead of an iso formatted date We do not need to format the date, DBIC handles DateTime correctly. It fixes t/db_dependent/Letters.t with new SQL modes Test plan: prove t/db_dependent/Letters.t prove t/db_dependent/Koha/Acquisition/Order.t Must return green
Created attachment 72163 [details] [review] Bug 20199: Send a DateTime to DBIC instead of an iso formatted date We do not need to format the date, DBIC handles DateTime correctly. It fixes t/db_dependent/Letters.t with new SQL modes Test plan: prove t/db_dependent/Letters.t prove t/db_dependent/Koha/Acquisition/Order.t Must return green Signed-off-by: Roch D'Amour <roch.damour@inlibro.com>
Created attachment 72166 [details] [review] Bug 20199: Add tests for Koha::Acq::Order->store Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 72167 [details] [review] Bug 20199: Send a DateTime to DBIC instead of an iso formatted date We do not need to format the date, DBIC handles DateTime correctly. It fixes t/db_dependent/Letters.t with new SQL modes Test plan: prove t/db_dependent/Letters.t prove t/db_dependent/Koha/Acquisition/Order.t Must return green Signed-off-by: Roch D'Amour <roch.damour@inlibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to master for 18.05, thanks to everybody involved!
I think this is not needed for 17.11, let me know if I am wrong