Triggered by: <Joubu> could you take a look at the noise of t/db_dependent/FrameworkPlugin.t? I took a look. And saw something else :) If you dont have CPL, the test crashes. Note that the noise is not from the test, but from poorly written plugins. Especially the unimarc plugins generate much uninitialized value and substr outside of string warnings. We should not have added Modern::Perl in one pass imo, but consider them one by one.. See bug 19996. I have been working on those plugins, but stranded so far on lack of support.
Created attachment 71640 [details] [review] Bug 20204: Add TestBuilder to replace CPL branch Remove CPL; without this branch, the test crashes. Rearrange modules at the start. Add Koha::Database calls. Move a few global my vars to our level. Remove intermediate rollbacks. Test plan: [1] Run prove t/db_dependent/FrameworkPlugin.t Ignore noise from unimarc plugins :) Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signing off myself: trivial edits.
Patch pushed to master for 18.05 Thanks Marcel