Bug 20222 - Make bread crumb for cleanborrowers.pl match the link text in tools-home.pl
Summary: Make bread crumb for cleanborrowers.pl match the link text in tools-home.pl
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Tools (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-02-15 20:20 UTC by Barton Chittenden
Modified: 2019-10-14 19:56 UTC (History)
0 users

See Also:
Change sponsored?: ---
Patch complexity: String patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments
Bug 20222 - The bread crumb for cleanborrowers.pl does not match the link text in tools-home.pl (1.95 KB, patch)
2018-02-16 14:38 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 20222 - The bread crumb for cleanborrowers.pl does not match the link text in tools-home.pl (2.01 KB, patch)
2018-02-16 19:18 UTC, Roch D'Amour
Details | Diff | Splinter Review
Bug 20222: Make bread crumb for cleanborrowers.pl match the link text in tools-home.pl (2.06 KB, patch)
2018-02-18 10:45 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Barton Chittenden 2018-02-15 20:20:29 UTC
In Home › Tools (tools/tools-home.pl), the link to the patron batch deletion tool is

    Batch patron deletion/anonymization

When you click into the page, the breadcrumb says

    Home › Tools › Clean Patron Records

The breadcrumb should match the link text.
Comment 1 Owen Leonard 2018-02-16 14:38:23 UTC
Created attachment 71797 [details] [review]
Bug 20222 - The bread crumb for cleanborrowers.pl does not match the link text in tools-home.pl

This patch revises the breadcrumbs in the template for batch patron
deletion / anonymization so that they match the text used in the tools
menu and on Tools home.

To test, apply the patch and go through a batch patron anonymization
process. At each step the breadcrumbs should read "Batch patron
deletion/anonymization" instead of "clean patron records."
Comment 2 Roch D'Amour 2018-02-16 19:18:22 UTC
Created attachment 71858 [details] [review]
Bug 20222 - The bread crumb for cleanborrowers.pl does not match the link text in tools-home.pl

This patch revises the breadcrumbs in the template for batch patron
deletion / anonymization so that they match the text used in the tools
menu and on Tools home.

To test, apply the patch and go through a batch patron anonymization
process. At each step the breadcrumbs should read "Batch patron
deletion/anonymization" instead of "clean patron records."

Signed-off-by: Roch D'Amour <roch.damour@inlibro.com>
Comment 3 Katrin Fischer 2018-02-18 10:45:53 UTC
Created attachment 71900 [details] [review]
Bug 20222: Make bread crumb for cleanborrowers.pl match the link text in tools-home.pl

This patch revises the breadcrumbs in the template for batch patron
deletion / anonymization so that they match the text used in the tools
menu and on Tools home.

To test, apply the patch and go through a batch patron anonymization
process. At each step the breadcrumbs should read "Batch patron
deletion/anonymization" instead of "clean patron records."

Signed-off-by: Roch D'Amour <roch.damour@inlibro.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 4 Katrin Fischer 2018-02-18 10:46:57 UTC
https://wiki.koha-community.org/wiki/Commit_messages ;)
Comment 5 Jonathan Druart 2018-02-18 19:50:49 UTC
Pushed to master for 18.05, thanks to everybody involved!