And we could then remove it. http://irc.koha-community.org/koha/2013-06-26#i_1333289 http://irc.koha-community.org/koha/2013-06-26#i_1333589
Created attachment 72048 [details] [review] Bug 20264: Remove syspref checkdigit According to http://irc.koha-community.org/koha/2013-06-26#i_1333289 http://irc.koha-community.org/koha/2013-06-26#i_1333589 and Hea data, this syspref is no longer in used and is always set to false.
Created attachment 72049 [details] [review] Bug 20264: Remove syspref checkdigit According to http://irc.koha-community.org/koha/2013-06-26#i_1333289 http://irc.koha-community.org/koha/2013-06-26#i_1333589 and Hea data, this syspref is no longer in used and is always set to false.
Patch failed to apply with the following error message: vagrant@kohadevbox:kohaclone(master)$ git bz apply -s 20264 Bug 20264 - Syspref checkdigit is no longer in used 72049 - Bug 20264: Remove syspref checkdigit Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 20264: Remove syspref checkdigit fatal: sha1 information is lacking or useless (C4/Members.pm). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Bug 20264: Remove syspref checkdigit The copy of the patch that failed is found in: /home/vagrant/kohaclone/.git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-20264-Remove-syspref-checkdigit-H8JTSx.patch vagrant@kohadevbox:kohaclone(master|AM 1/1)$
Created attachment 72289 [details] [review] Bug 20264: Remove syspref checkdigit According to http://irc.koha-community.org/koha/2013-06-26#i_1333289 http://irc.koha-community.org/koha/2013-06-26#i_1333589 and Hea data, this syspref is no longer in used and is always set to false.
(In reply to Jonathan Druart from comment #4) > According to > http://irc.koha-community.org/koha/2013-06-26#i_1333289 > http://irc.koha-community.org/koha/2013-06-26#i_1333589 > and Hea data, this syspref is no longer in used and is always set to > false. Does this provide enough evidence? Can we make some more noise on the mailing lists(?) in order to let people step up and say Hey I am still using that?
https://lists.katipo.co.nz/pipermail/koha/2018-March/050046.html
Created attachment 72396 [details] [review] Bug 20264: Remove syspref checkdigit According to http://irc.koha-community.org/koha/2013-06-26#i_1333289 http://irc.koha-community.org/koha/2013-06-26#i_1333589 and Hea data, this syspref is no longer in used and is always set to false. Signed-off-by: Dilan Johnpullé <dilan@calyx.net.au>
(In reply to Dilan Johnpullé from comment #7) > Created attachment 72396 [details] [review] [review] > Bug 20264: Remove syspref checkdigit > > According to > http://irc.koha-community.org/koha/2013-06-26#i_1333289 > http://irc.koha-community.org/koha/2013-06-26#i_1333589 > and Hea data, this syspref is no longer in used and is always set to > false. > Patch applies now and works as expected. > Signed-off-by: Dilan Johnpullé <dilan@calyx.net.au>
Created attachment 72406 [details] [review] Bug 20264: Remove syspref checkdigit According to http://irc.koha-community.org/koha/2013-06-26#i_1333289 http://irc.koha-community.org/koha/2013-06-26#i_1333589 and Hea data, this syspref is no longer in used and is always set to false. Signed-off-by: Dilan Johnpullé <dilan@calyx.net.au> Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Pushed to master for 18.05, thanks to everybody involved!
Enhancement, not backported for 17.11
Hi! Just stumbled upon this in 17.11 and 17.05 when this syspref is on. Upon saving a patron without putting any cardnumber, since autoMemberNum and checkdigit is both turned on, I am getting the following error: DBIx::Class::Storage::DBI::_dbh_execute(): Duplicate entry "V18" for key 'cardnumber' at /usr/share/koha/lib/Koha/Object.pm line 121 With this being said, all the more this system preference setting should go. I just put in this comment since it's related to this bug no. Should this also be backported to 17.11 and 17.05?