If text is added to the system preference ILLModuleCopyrightClearance then you are unable to place an ILL request in the OPAC. You get a list of the backends but, upon selecting any of them, you get an internal server error. Error log shows: Template process failed: file error - : not found at /usr/share/koha/lib/C4/Templates.pm line 122.
Upping severity as the feature is broken at the OPAC.
Created attachment 73870 [details] [review] Bug [20284] - [ILL: Adding a 'new request' from ..] This patch fixes the display of the copyright notice text that is defined in ILLModuleCopyrightClearance preference when placing ILL requests from the OPAC. Handling of the copyrightclearance stage was missing, this has been added. Test plan: - Ensure you have at least one ILL backend available: https://wiki.koha-community.org/wiki/ILL_backends - Ensure you have the "ILLModule" preference enabled - Add some text to the "ILLModuleCopyrightClearance" preference - Navigate to a search results page in the catalog - Click the "Make an Interlibrary Loan request" link at the bottom - Choose "Create a new request", then select a backend - TEST: Check the text you added earlier is displayed with buttons for agreeing or disagreeing (prior to this patch, this screen displayed an error) - TEST: Check that clicking "Yes" takes you to the form for adding request details - TEST: Check that clicking "No" takes you back to the "Interlibrary loan requests" page
Created attachment 74156 [details] [review] Bug 20284: ILLModuleCopyrightClearance text breaks This patch fixes the display of the copyright notice text that is defined in ILLModuleCopyrightClearance preference when placing ILL requests from the OPAC. Handling of the copyrightclearance stage was missing, this has been added. To test: 1) Ensure you have at least one ILL backend available: https://wiki.koha-community.org/wiki/ILL_backends 2) Ensure you have the "ILLModule" preference enabled 3) Add some text to the "ILLModuleCopyrightClearance" preference 4) Navigate to a search results page in the catalog 5) Click the "Make an Interlibrary Loan request" link at the bottom 6) Choose "Create a new request", then select a backend 7) Observe the text you added earlier is displayed with buttons for agreeing or disagreeing (prior to this patch, this screen displayed an error) 8) Observe that clicking "Yes" takes you to the form for adding request details 9) Observe that clicking "No" takes you back to the "Interlibrary loan requests" page
Created attachment 74426 [details] [review] Bug 11674: DBRev 17.12.00.031 Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
ummm, really not sure what happened here. I have signed this patch off but I seem to have contaminated it with a completely different bug. Suggestions welcome!
Signed off as previous comment
(In reply to Barry Cannon from comment #5) > ummm, really not sure what happened here. I have signed this patch off but I > seem to have contaminated it with a completely different bug. > Suggestions welcome! Hi Barry, you just attached the last commit from top of master, not from branch with this patch applied.
(In reply to Barry Cannon from comment #5) > ummm, really not sure what happened here. I have signed this patch off but I > seem to have contaminated it with a completely different bug. > Suggestions welcome! Will add your signoff line (for this time ;)
Created attachment 74599 [details] [review] Bug 20284: ILLModuleCopyrightClearance text breaks This patch fixes the display of the copyright notice text that is defined in ILLModuleCopyrightClearance preference when placing ILL requests from the OPAC. Handling of the copyrightclearance stage was missing, this has been added. To test: 1) Ensure you have at least one ILL backend available: https://wiki.koha-community.org/wiki/ILL_backends 2) Ensure you have the "ILLModule" preference enabled 3) Add some text to the "ILLModuleCopyrightClearance" preference 4) Navigate to a search results page in the catalog 5) Click the "Make an Interlibrary Loan request" link at the bottom 6) Choose "Create a new request", then select a backend 7) Observe the text you added earlier is displayed with buttons for agreeing or disagreeing (prior to this patch, this screen displayed an error) 8) Observe that clicking "Yes" takes you to the form for adding request details 9) Observe that clicking "No" takes you back to the "Interlibrary loan requests" page Signed-off-by: Barry Cannon <bc@interleaf.ie>
Redirect without exit. See other bug?
Created attachment 74652 [details] [review] Bug 20284: (follow-up) Added missing 'exit's This patch adds the exits that were missing after the redirects
Skipping SO for the follow-up.
Created attachment 75079 [details] [review] Bug 20284: ILLModuleCopyrightClearance text breaks This patch fixes the display of the copyright notice text that is defined in ILLModuleCopyrightClearance preference when placing ILL requests from the OPAC. Handling of the copyrightclearance stage was missing, this has been added. To test: 1) Ensure you have at least one ILL backend available: https://wiki.koha-community.org/wiki/ILL_backends 2) Ensure you have the "ILLModule" preference enabled 3) Add some text to the "ILLModuleCopyrightClearance" preference 4) Navigate to a search results page in the catalog 5) Click the "Make an Interlibrary Loan request" link at the bottom 6) Choose "Create a new request", then select a backend 7) Observe the text you added earlier is displayed with buttons for agreeing or disagreeing (prior to this patch, this screen displayed an error) 8) Observe that clicking "Yes" takes you to the form for adding request details 9) Observe that clicking "No" takes you back to the "Interlibrary loan requests" page Signed-off-by: Barry Cannon <bc@interleaf.ie> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Created attachment 75080 [details] [review] Bug 20284: (follow-up) Added missing 'exit's This patch adds the exits that were missing after the redirects Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Created attachment 75081 [details] [review] Bug 20284: (QA follow-up) superlibrarian has ill permissions Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Created attachment 75082 [details] [review] Bug 20284: Fix minor compilation errors Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Pushed to master for 18.05, thanks to everybody involved!
*** Bug 20646 has been marked as a duplicate of this bug. ***