Due to a simple typo, the accountline passed to Koha::Account::pay from _FixAccountForLostAndReturned is not used. That means that the credit for the lost item fee may be applied to other fees before it is used on the lost fee itself.
Created attachment 72122 [details] [review] Bug 20286: Unit Test
Created attachment 72123 [details] [review] Bug 20285: Lost item refund won't always pay down lost item fee first Due to a simple typo, the accountline passed to Koha::Account::pay from _FixAccountForLostAndReturned is not used. That means that the credit for the lost item fee may be applied to other fees before it is used on the lost fee itself. Test Plan: 1) Find a patron with existing fines 2) Ensure your settings will charge patrons for lost items 3) Check out an item to a patron with existing fees that need paid 4) Mark the item lost, charging the lost item fee 5) Return the item 6) Note the fee was refunded, but it paid down earlier fines first, and not the lost item fee first 7) Apply this patch set 8) Repeat steps 1 - 5 9) Note the lost item fee is the first fee to be paid off by the lost item fee refund
Created attachment 75936 [details] [review] Bug 20285: Lost item refund won't always pay down lost item fee first Due to a simple typo, the accountline passed to Koha::Account::pay from _FixAccountForLostAndReturned is not used. That means that the credit for the lost item fee may be applied to other fees before it is used on the lost fee itself. Test Plan: 1) Find a patron with existing fines 2) Ensure your settings will charge patrons for lost items 3) Check out an item to a patron with existing fees that need paid 4) Mark the item lost, charging the lost item fee 5) Return the item 6) Note the fee was refunded, but it paid down earlier fines first, and not the lost item fee first 7) Apply this patch set 8) Repeat steps 1 - 5 9) Note the lost item fee is the first fee to be paid off by the lost item fee refund Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> Followed the test plan and it works as expected.
Is this really minor?
Caused by bug 14826? Is this bug present in 17.11?
Created attachment 76060 [details] [review] Bug 20285: Unit Test Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 76061 [details] [review] Bug 20285: Lost item refund won't always pay down lost item fee first Due to a simple typo, the accountline passed to Koha::Account::pay from _FixAccountForLostAndReturned is not used. That means that the credit for the lost item fee may be applied to other fees before it is used on the lost fee itself. Test Plan: 1) Find a patron with existing fines 2) Ensure your settings will charge patrons for lost items 3) Check out an item to a patron with existing fees that need paid 4) Mark the item lost, charging the lost item fee 5) Return the item 6) Note the fee was refunded, but it paid down earlier fines first, and not the lost item fee first 7) Apply this patch set 8) Repeat steps 1 - 5 9) Note the lost item fee is the first fee to be paid off by the lost item fee refund Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> Followed the test plan and it works as expected. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Awesome work all! Pushed to master for 18.11
Pushed to 18.05.x for 18.05.01
Pushed to 17.11.x for 17.11.07