Created attachment 72174 [details] [review] Bug 20291: Add a StaffLoginInstructions preference for adding text to staff client login To test: 1 - Apply patches 2 - Upgrade database 3 - Check the staff client login page, should be no change 4 - Add something to the preferene 5 - It should appear on the login page
Created attachment 72204 [details] [review] Bug 20291: Add a StaffLoginInstructions preference for adding text to staff client login To test: 1 - Apply patches 2 - Upgrade database 3 - Check the staff client login page, should be no change 4 - Add something to the preferene 5 - It should appear on the login page Signed-off-by: Owen Leonard <oleonard@myacpl.org>
You have missed the update to sysprefs.sql!
Created attachment 72253 [details] [review] Bug 20291: (follow-up) Add sysprefs.sql changes Current status: Failed QA
Created attachment 73370 [details] [review] Bug 20291: Add a StaffLoginInstructions preference for adding text to staff client login To test: 1 - Apply patches 2 - Upgrade database 3 - Check the staff client login page, should be no change 4 - Add something to the preferene 5 - It should appear on the login page Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 73371 [details] [review] Bug 20291: (follow-up) Add sysprefs.sql changes Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
StaffLoginInstructions vs NoLoginInstructions That is wrong, I think it should be: NoLoginInstructions for Staff and OPACNoLoginInstructions for OPAC It seems to be the pattern we follow for other prefs. Do not you think?
The 'no' in the pref for opac never made sense to me. Why not OPACLoginInstructions and (Staff)LoginInstructions? If we are to go and rename.
I agree with Katrin 'NoLoginInstructions' is very awkward, StaffLoginInstructions and OPACLoginInstructions if much more clear
Created attachment 73413 [details] [review] Bug 20291: (follow-up) Rename NoLoginInstructions to OpacLoginInstructions
Nick, you need to s/NoLoginInstructions/OpacLoginInstructions/g correctly :) Double-check the following files: koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-auth.tt koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-main.tt
Created attachment 73435 [details] [review] Bug 20291: (follow-up) Rename NoLoginInstructions to OpacLoginInstructions
Should make a note about the named syp pref in the release notes, but fully agree with the changes.
Pushed to master for 18.05, thanks to everybody involved!
Enhancement, not backporting to 17.11.x