If you have multiple languages installed, the notices and slips page uses the same HTML id multiple times, once for each language. This prevents eg. the SMS character count javascript from working, because each of the textareas has the same id.
Created attachment 72293 [details] [review] Bug 20298: Fix SMS characters counter when TranslateNotices is set If you have multiple languages installed, the notices and slips page uses the same HTML id multiple times, once for each language. This prevents eg. the SMS character count javascript from working, because each of the textareas has the same id. Test plan: Test the sms characters counter, with and without TranslateNotices Make sure other features on this page still work correctly QA: Make sure this change of id did not break something else.
Also: tools/letter.pl: my $is_html = $input->param("is_html_$mtt"); And I'd guess all of the id attributes in the template within the "FOREACH lang IN letters.keys" -loop need to be verified, not just the sms ones ... :/
(In reply to paxed from comment #2) > Also: > tools/letter.pl: my $is_html = $input->param("is_html_$mtt"); > Derp, nevermind, that's the name, not the id.
Created attachment 72993 [details] [review] Bug 20298: Fix SMS characters counter when TranslateNotices is set If you have multiple languages installed, the notices and slips page uses the same HTML id multiple times, once for each language. This prevents eg. the SMS character count javascript from working, because each of the textareas has the same id. Test plan: Test the sms characters counter, with and without TranslateNotices Make sure other features on this page still work correctly QA: Make sure this change of id did not break something else. Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com>
Created attachment 73238 [details] [review] Bug 20298: Fix SMS characters counter when TranslateNotices is set If you have multiple languages installed, the notices and slips page uses the same HTML id multiple times, once for each language. This prevents eg. the SMS character count javascript from working, because each of the textareas has the same id. Test plan: Test the sms characters counter, with and without TranslateNotices Make sure other features on this page still work correctly QA: Make sure this change of id did not break something else. Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to master for 18.05, thanks to everybody involved!
Created attachment 73792 [details] [review] Bug 20298: (follow-up) fix labels' for attributes
(In reply to Jonathan Druart from comment #7) > Created attachment 73792 [details] [review] [review] > Bug 20298: (follow-up) fix labels' for attributes Pushed to master for 18.05