Bug 18336 displays: + print "Upgrade to $DBversion done (Bug 18336: Convert DB tables to utf8mb4 [U+1F4A9])\n"; It could be wrongly interpreted by new Koha users, we should change this emoji
Please suggest something else :)
https://emojipedia.org/wrapped-present/
(In reply to Owen Leonard from comment #2) > https://emojipedia.org/wrapped-present/ +1
https://emojipedia.org/smiling-face-with-smiling-eyes/ Just for you know, an alternative. [U+1F60A]
(I don't care either way, but yes we should get rid of the poo.)
[U+1F4AF] [U+1F469][U+1F4BB][U+1F468][U+1F4BB] [U+1F195][U+1F193] [U+1F6A9] [U+1F3C1] ✔ ▶ [U+1F511] [U+1F4B2][U+1F4B2][U+1F4B2] [U+1F4B0] [U+1F4DA] [U+1F4D6] [U+1F4C0] [U+1F4BF] [U+1F4BE] [U+1F50B] [U+1F50A] [U+1F525] Ok I really could just go forever here https://unicode.org/emoji/charts/full-emoji-list.html
(In reply to Owen Leonard from comment #2) > https://emojipedia.org/wrapped-present/ I am for this as "koha" means "gift" ;)
Created attachment 73176 [details] [review] Bug 20299 - Is Koha installer suggesting Koha is shit? This patch updates the database update script replacing the "pile of poo" emoji with the "wrapped gift" emoji. To test, apply the patch and go to Administration -> System preferences -> Local use. Set the "Version" preference back to trigger a database update. Go through the database update process and confirm that the "Convert DB tables to utf8mb4" upgrade message includes a gift emoji.
Created attachment 73179 [details] [review] Bug 20299 - Koha is a gift This patch updates the database update script replacing the "pile of poo" emoji with the "wrapped gift" emoji. To test, apply the patch and go to Administration -> System preferences -> Local use. Set the "Version" preference back to trigger a database update. Go through the database update process and confirm that the "Convert DB tables to utf8mb4" upgrade message includes a gift emoji.
Created attachment 73224 [details] [review] Bug 20299 - Koha is a gift This patch updates the database update script replacing the "pile of poo" emoji with the "wrapped gift" emoji. To test, apply the patch and go to Administration -> System preferences -> Local use. Set the "Version" preference back to trigger a database update. Go through the database update process and confirm that the "Convert DB tables to utf8mb4" upgrade message includes a gift emoji. Signed-off-by: Mason James <mtj@kohaaloha.com>
(In reply to Owen Leonard from comment #9) > Created attachment 73179 [details] [review] [review] > Bug 20299 - Koha is a gift > > This patch updates the database update script replacing the "pile of > poo" emoji with the "wrapped gift" emoji. ..looks good to me [U+1F44D]
Created attachment 73225 [details] [review] Bug 20299 - Koha is a gift This patch updates the database update script replacing the "pile of poo" emoji with the "wrapped gift" emoji. To test, apply the patch and go to Administration -> System preferences -> Local use. Set the "Version" preference back to trigger a database update. Go through the database update process and confirm that the "Convert DB tables to utf8mb4" upgrade message includes a gift emoji. Signed-off-by: Mason James <mtj@kohaaloha.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Thx Owen! Plz remember : not - in subject :)
Created attachment 73226 [details] [review] Bug 20299: Koha is a gift This patch updates the database update script replacing the "pile of poo" emoji with the "wrapped gift" emoji. To test, apply the patch and go to Administration -> System preferences -> Local use. Set the "Version" preference back to trigger a database update. Go through the database update process and confirm that the "Convert DB tables to utf8mb4" upgrade message includes a gift emoji. Signed-off-by: Mason James <mtj@kohaaloha.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to master for 18.05, thanks to everybody involved!
Awesoem work all, depends on patches which are not in stable, not backporting.