If there is no "authorised by" value on the order the "receive" option fails with 500 error. The file called is orderreceive.pl?ordernumber=1234&invoiceid=1234 orderreceive.pl should check if authorised_by exists before looking up patron information.
I guess this is caused by bug 17829.
Created attachment 72281 [details] [review] Bug 20303: Do not explode when receiving an order if authorisedby not set
Barry, do you have more info about how it happens? I guess it can happen on a very old DB (before aqbaskets.authorisedby) or if the librarian record has been deleted.
Yes, this manifested itself after an upgrade from an older version so it could be that this might not be possible if starting acquisitions from current.
Created attachment 72522 [details] [review] Bug 20303: Do not explode when receiving an order if authorisedby not set Reproduced by deleting user and patron to notify before clicking Receive. Patch works. Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Created attachment 72536 [details] [review] Bug 20303: Do not explode when receiving an order if authorisedby not set Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Pushed to master for 18.05, thanks to all for your hard work.
Awesome work all! Pushed to stable for 17.11.04
Not in 17.05.x since Bug 17829 not in it