Bug 20339 - Unify MARC21 ISBN/ISSN handling in XSLT in the staff interface
Summary: Unify MARC21 ISBN/ISSN handling in XSLT in the staff interface
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Staff interface (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement
Assignee: paxed
QA Contact: Martin Renvoize (ashimema)
URL:
Keywords:
Depends on:
Blocks: 28984
  Show dependency tree / graph
 
Reported: 2018-03-06 10:20 UTC by paxed
Modified: 2021-09-09 14:39 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:

Attachments
Bug 20339: Unify MARC21 ISBN/ISSN handling in XSL (6.50 KB, patch)
2018-03-06 10:23 UTC, paxed 		Details | Diff | Splinter Review
Bug 20339: Unify MARC21 ISBN/ISSN handling in XSL (6.53 KB, patch)
2018-03-12 13:22 UTC, Biblibre Sandboxes 		Details | Diff | Splinter Review
Bug 20339: Unify MARC21 ISBN/ISSN handling in XSL (6.62 KB, patch)
2018-06-06 12:02 UTC, Martin Renvoize (ashimema) 		Details | Diff | Splinter Review
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description paxed 2018-03-06 10:20:23 UTC 
The code to show the ISBN and ISSN is repeated between the search results and the detail view. Create a function to show the ISBN/ISSN, and call that instead.
Comment 1 paxed 2018-03-06 10:23:52 UTC 
Created attachment 72467 [details] [review]
Bug 20339: Unify MARC21 ISBN/ISSN handling in XSL

The code to show the ISBN and ISSN is repeated between the search results
and the detail view. Create a function to show the ISBN/ISSN, and call
that instead.

Test plan:
1) Apply patch
2) Search for any records, check that the ISBN and ISSN are shown
   correctly
3) Go to biblio detail pages, check that the ISBN and ISSN are shown
   correctly
Comment 2 Biblibre Sandboxes 2018-03-12 13:22:10 UTC 
Patch tested with a sandbox, by claude <claude.brayer@cea.fr>
Comment 3 Biblibre Sandboxes 2018-03-12 13:22:32 UTC 
Created attachment 72683 [details] [review]
Bug 20339: Unify MARC21 ISBN/ISSN handling in XSL

The code to show the ISBN and ISSN is repeated between the search results
and the detail view. Create a function to show the ISBN/ISSN, and call
that instead.

Test plan:
1) Apply patch
2) Search for any records, check that the ISBN and ISSN are shown
   correctly
3) Go to biblio detail pages, check that the ISBN and ISSN are shown
   correctly

Signed-off-by: Pasi Kallinen <pasi.kallinen@joensuu.fi>

Signed-off-by: claude <claude.brayer@cea.fr>
Comment 4 Martin Renvoize (ashimema) 2018-06-06 12:02:17 UTC 
Created attachment 75847 [details] [review]
Bug 20339: Unify MARC21 ISBN/ISSN handling in XSL

The code to show the ISBN and ISSN is repeated between the search results
and the detail view. Create a function to show the ISBN/ISSN, and call
that instead.

Test plan:
1) Apply patch
2) Search for any records, check that the ISBN and ISSN are shown
   correctly
3) Go to biblio detail pages, check that the ISBN and ISSN are shown
   correctly

Signed-off-by: Pasi Kallinen <pasi.kallinen@joensuu.fi>

Signed-off-by: claude <claude.brayer@cea.fr>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 5 Martin Renvoize (ashimema) 2018-06-06 12:02:52 UTC 
Looks solid and works as expected.. always nice to dry out some code a little :)
Comment 6 Nick Clemens (kidclamp) 2018-06-22 18:11:55 UTC 
Awesome work all!

Pushed to master for 18.11.x
Comment 7 Martin Renvoize (ashimema) 2018-06-27 09:37:50 UTC 
Enhancement, not backporting for 18.05.x series.