Bug 2034 - circ/billing.pl needs the more complex code to achieve goals for large data sets
Summary: circ/billing.pl needs the more complex code to achieve goals for large data sets
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Circulation (show other bugs)
Version: 3.8
Hardware: All All
: P3 normal (vote)
Assignee: Katrin Fischer
QA Contact:
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-04-23 10:07 UTC by Chris Cormack
Modified: 2013-12-05 20:05 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 2034: Removing unused scripts billig.pl/billing.tt (14.52 KB, patch)
2012-04-08 09:28 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 2034: Removing unused scripts billig.pl/billing.tt (14.57 KB, patch)
2012-04-09 03:06 UTC, Chris Cormack
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Cormack 2010-05-21 00:37:26 UTC


---- Reported by drdrulm@yahoo.com 2008-04-23 10:07:39 ----

Tested my own billing.pl on SMFPL's larger data set and it times out! I thought this may have been a problem. So I can use the original setup I had to do this which is more complex but breaks up the SQL into sections making PHP/Perl do more of the work--also the results for the charges will have more detail.

When I get to it.
D.Ulm



---- Additional Comments From drdrulm@yahoo.com 2008-07-28 13:50:19 ----

Put a patch in to remove this billing.pl link from circulation-home.tmpl. 

InnoDB (as you know) cannot do things link count(*), etc. quickly. 

Need to totally change the MySQL code before any reasonable report can be created.




---- Additional Comments From nengard@gmail.com 2009-12-23 17:58:57 ----

This bug hasn't been touched in nearly a year, please revisit and test and close if appropriate.



--- Bug imported by chris@bigballofwax.co.nz 2010-05-21 00:37 UTC  ---

This bug was previously known as _bug_ 2034 at http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=2034

Actual time not defined. Setting to 0.0
The original reporter of this bug does not have
   an account here. Reassigning to the person who moved
   it here: chris@bigballofwax.co.nz.
   Previous reporter was drdrulm@yahoo.com.
CC member drdrulm@yahoo.com does not have an account here

Comment 1 Owen Leonard 2011-02-23 14:11:58 UTC
If this script is to be kept, let's fix it. Otherwise let's just remove it.
Comment 2 Chris Cormack 2012-04-07 21:59:31 UTC
I vote remove it, it is a pile of spaghetti sql, which can more easily be done in a report.
Comment 3 Katrin Fischer 2012-04-08 09:28:12 UTC Comment hidden (obsolete)
Comment 4 Chris Cormack 2012-04-09 03:06:45 UTC
Created attachment 9032 [details] [review]
Bug 2034: Removing unused scripts billig.pl/billing.tt

- Scripts are currently not linked from anywhere in the templates
- Functionality can also be achieved with a custom report
- There are unresolved problems with the sql in the existig scripts

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Comment 5 Ian Walls 2012-04-09 19:53:39 UTC
Successfully removes this script from the system; since it was functionally inaccessible, and problematic.  Passed QA.
Comment 6 Jared Camins-Esakov 2012-05-24 00:57:14 UTC
This will not be included in 3.6.x, just in case someone is using the script somehow.
Comment 7 Jared Camins-Esakov 2012-12-31 01:00:51 UTC
There have been no further reports of problems so I am marking this bug resolved.