Our SMS gateway provider requires that only one specific email address is used in as sender for all emails. This patch adds a system preference for setting "from" address for all mails sent by the Email SMS send driver.
Created attachment 72517 [details] [review] Bug 20356 - Add EmailSMSSendDriverFromAddress system preference Add EmailSMSSendDriverFromAddress system preference for overriding Email SMS send driver from address. How to test: 1. Run tests in t/db_dependent/Letters.t 2. All tests should pass
Created attachment 72518 [details] [review] Bug 20356: Add EmailSMSSendDriverFromAddress system preference Add EmailSMSSendDriverFromAddress system preference for overriding Email SMS send driver from address. How to test: 1) Run tests in t/db_dependent/Letters.t 2) All tests should pass Sponsored-by: Gothenburg University Library
Created attachment 75111 [details] [review] Bug 20356: Add EmailSMSSendDriverFromAddress system preference Add EmailSMSSendDriverFromAddress system preference for overriding Email SMS send driver from address. How to test: 1) Run tests in t/db_dependent/Letters.t 2) All tests should pass Sponsored-by: Gothenburg University Library
Rebased against Koha master.
Please rebase on master, I'll test it.
Created attachment 79712 [details] [review] Bug 20356: Add EmailSMSSendDriverFromAddress system preference Add EmailSMSSendDriverFromAddress system preference for overriding Email SMS send driver from address. How to test: 1) Run tests in t/db_dependent/Letters.t 2) All tests should pass Sponsored-by: Gothenburg University Library
Created attachment 79760 [details] [review] Bug 20356: Add EmailSMSSendDriverFromAddress system preference Add EmailSMSSendDriverFromAddress system preference for overriding Email SMS send driver from address. How to test: 1) Run tests in t/db_dependent/Letters.t 2) All tests should pass Sponsored-by: Gothenburg University Library Signed-off-by: Michal Denar <black23@gmail.com>
Should not it be defined at provider level instead (table sms_providers)? Just asking ;)
Yes, I agree that would probably be better. I think I made just the minimal effort to fix the problem (for us) and thought that I might refactor this later to add the setting on provider level. Could set this to "needs work" and I might fix this later, or if any one else have the time to do so.
The things is that it would be done later, but will require more work (remove the code, update the DB, etc.) Not a big deal anyway. I will let the status as "Needs QA" to let another QAer give their opinion.
*could* be done
(In reply to Jonathan Druart from comment #10) > The things is that it would be done later, but will require more work > (remove the code, update the DB, etc.) > Not a big deal anyway. > I will let the status as "Needs QA" to let another QAer give their opinion. As this is required by specific provider, it should be done on provider level I think.
Created attachment 81875 [details] [review] Bug 20356: Add EmailSMSSendDriverFromAddress system preference Add EmailSMSSendDriverFromAddress system preference for overriding Email SMS send driver from address. How to test: 1) Run tests in t/db_dependent/Letters.t 2) All tests should pass Sponsored-by: Gothenburg University Library Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Not a blocker for me. Very specific and small issue, easy to move to provider db on a new report. Please open one, David. Passed QA
Awesome work all! Pushed to master for 18.11
Enhancement, will not be backported to 18.05.x series.