Bug 20457 - Overdue and pre-overdue cronjobs not skipping phone notices
Summary: Overdue and pre-overdue cronjobs not skipping phone notices
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Kyle M Hall
QA Contact: Katrin Fischer
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-03-21 15:52 UTC by Kyle M Hall
Modified: 2023-12-28 20:43 UTC (History)
8 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
22.11.00, 22.05.07, 21.11.15


Attachments
Bug 20457: Overdue and pre-overdue cronjobs not skipping phone notices (3.50 KB, patch)
2018-03-21 15:53 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 20457: Overdue and pre-overdue cronjobs not skipping phone notices (3.06 KB, patch)
2019-03-25 18:04 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 20457: Overdue and pre-overdue cronjobs not skipping phone notices (3.04 KB, patch)
2021-01-19 11:59 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 20457: Overdue and pre-overdue cronjobs not skipping phone notices (3.16 KB, patch)
2022-09-05 20:07 UTC, Joonas Kylmälä
Details | Diff | Splinter Review
Bug 20457: Overdue and pre-overdue cronjobs not skipping phone notices (3.22 KB, patch)
2022-10-03 16:34 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Kyle M Hall 2018-03-21 15:52:15 UTC
The overdue and pre-overdue cron scripts are not skipping the generation of phone notices. This causes many phone notices to be created that will always be left at 'pending' as the Talking Tech outbound script creates its own phone notices and puts them in the message queue.
Comment 1 Kyle M Hall 2018-03-21 15:53:53 UTC
Created attachment 73141 [details] [review]
Bug 20457: Overdue and pre-overdue cronjobs not skipping phone notices

The overdue and pre-overdue cron scripts are not skipping the generation of phone notices. This causes many phone notices to be created that will always be left at 'pending' as the Talking Tech outbound script creates its own phone notices and puts them in the message queue.

Test Plan:
1) Enable Talking Tech
2) Enable predue and overdue notice phone transports for a patron
3) Generate overdues and predues, notice phone notices are generated
4) Apply the patch
5) Repeat steps 2-3
6) Note phone notices are not generated
Comment 2 Kyle M Hall 2018-03-21 15:56:16 UTC
Another good alternative would be to have TT stop generating it's own notices, and instead have it use the notices generated by Koha. This would require a huge overhaul of the system though, but it's a good idea for later.
Comment 3 Danielle Elder 2019-03-22 12:58:43 UTC
This is still an issue, and it confusing to many library staff to see these notices in the message queue.  It also makes support for the Talking Tech integration with Koha a bit more complicated to sort through. 

I volunteer as tribute to test/sign off on any patches.
Comment 4 Liz Rea 2019-03-23 01:42:03 UTC
Hi,

This doesn't seem to apply at the moment: 

CONFLICT (content): Merge conflict in misc/cronjobs/advance_notices.pl
error: Failed to merge in the changes.
Patch failed at 0001 Bug 20457: Overdue and pre-overdue cronjobs not skipping phone notices

Sorry :(

Liz
Comment 5 Kyle M Hall 2019-03-25 18:04:05 UTC
Created attachment 86990 [details] [review]
Bug 20457: Overdue and pre-overdue cronjobs not skipping phone notices

The overdue and pre-overdue cron scripts are not skipping the generation of phone notices. This causes many phone notices to be created that will always be left at 'pending' as the Talking Tech outbound script creates its own phone notices and puts them in the message queue.

Test Plan:
1) Enable Talking Tech
2) Enable predue and overdue notice phone transports for a patron
3) Generate overdues and predues, notice phone notices are generated
4) Apply the patch
5) Repeat steps 2-3
6) Note phone notices are not generated
Comment 6 Eden 2021-01-18 23:32:30 UTC
Can you please make a more detailed test plan for me to test your patch
Comment 7 Kyle M Hall 2021-01-19 11:59:52 UTC
Created attachment 115311 [details] [review]
Bug 20457: Overdue and pre-overdue cronjobs not skipping phone notices

The overdue and pre-overdue cron scripts are not skipping the generation of phone notices. This causes many phone notices to be created that will always be left at 'pending' as the Talking Tech outbound script creates its own phone notices and puts them in the message queue.

Test Plan:
1) Enable Talking Tech
2) Enable predue and overdue notice phone transports for a patron
3) Generate overdues and predues, notice phone notices are generated
4) Apply the patch
5) Repeat steps 2-3
6) Note phone notices are not generated
Comment 8 Joonas Kylmälä 2022-09-05 20:07:19 UTC
Created attachment 140213 [details] [review]
Bug 20457: Overdue and pre-overdue cronjobs not skipping phone notices

The overdue and pre-overdue cron scripts are not skipping the generation of phone notices. This causes many phone notices to be created that will always be left at 'pending' as the Talking Tech outbound script creates its own phone notices and puts them in the message queue.

Test Plan:
1) Enable Talking Tech
2) Enable predue and overdue notice phone transports for a patron
3) Generate overdues and predues, notice phone notices are generated
4) Apply the patch
5) Repeat steps 2-3
6) Note phone notices are not generated

Signed-off-by: Joonas Kylmälä <joonas.kylmala@iki.fi>
Comment 9 Katrin Fischer 2022-10-03 16:34:31 UTC
Created attachment 141280 [details] [review]
Bug 20457: Overdue and pre-overdue cronjobs not skipping phone notices

The overdue and pre-overdue cron scripts are not skipping the generation of phone notices. This causes many phone notices to be created that will always be left at 'pending' as the Talking Tech outbound script creates its own phone notices and puts them in the message queue.

Test Plan:
1) Enable Talking Tech
2) Enable predue and overdue notice phone transports for a patron
3) Generate overdues and predues, notice phone notices are generated
4) Apply the patch
5) Repeat steps 2-3
6) Note phone notices are not generated

Signed-off-by: Joonas Kylmälä <joonas.kylmala@iki.fi>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 10 Tomás Cohen Arazi 2022-10-03 17:14:33 UTC
Pushed to master for 22.11.

Nice work everyone, thanks!
Comment 11 Lucas Gass 2022-12-05 16:51:45 UTC
Backported to 22.05.x for upcoming 22.05.07 release
Comment 12 Arthur Suzuki 2022-12-14 12:06:47 UTC
applied to 21.11 for 21.11.15
Comment 13 wainuiwitikapark 2022-12-20 01:55:03 UTC
Backported to 21.05.x for 21.05.22
Comment 14 wainuiwitikapark 2022-12-23 00:25:58 UTC
Not released in 21.05.22
Comment 15 wainuiwitikapark 2023-03-15 00:39:16 UTC
(In reply to wainuiwitikapark from comment #14)
> Not released in 21.05.22

Reverted from 21.05 branch