When ordering from a staged file, and when items are NOT created at that time, the "item information" tab appears even though it is useless in this case. To reproduce : - Make sure system preference acqcreateitem is "cataloguing the record" or "receiving an order". - Make sure you have everything needed to place an order (currency, budget, vendor) 1. Stage a MARC file from Tools > Stage MARC records for import 2. Go to Acquisitions and create a basket for a vendor 3. Add to basket from staged file 4. Note that the "item information" tab is present, if you click on it, not that it is not useful
*** Bug 23585 has been marked as a duplicate of this bug. ***
Created attachment 144676 [details] [review] Bug 20473: Don't display 'Item information' tab when adding to basket from a file and not creating items This patch adds a conditional, and moves another up one level to remove the tab when it will have no content/effect To test: 1. Stage a MARC file from Tools > Stage MARC records for import 2. Go to Acquisitions and create a basket for a vendor 3. Add to basket from staged file 4. Note that the "item information" tab is present, if you click on it, not that it is not useful 5. Cancel adding to basket 6. Apply patch 7. Add to basket from the staged file again 8. Confirm there is no item information tab 9. Confirm orders are added on 'Save'
Created attachment 144677 [details] [review] Bug 20473: Whitespace
Created attachment 144678 [details] [review] Bug 20473: Don't display 'Item information' tab when adding to basket from a file and not creating items This patch adds a conditional, and moves another up one level to remove the tab when it will have no content/effect To test: 1. Stage a MARC file from Tools > Stage MARC records for import 2. Go to Acquisitions and create a basket for a vendor 3. Add to basket from staged file 4. Note that the "item information" tab is present, if you click on it, not that it is not useful 5. Cancel adding to basket 6. Apply patch 7. Add to basket from the staged file again 8. Confirm there is no item information tab 9. Confirm orders are added on 'Save'
Created attachment 144679 [details] [review] Bug 20473: Whitespace
Created attachment 144729 [details] [review] Bug 20473: Don't display 'Item information' tab when adding to basket from a file and not creating items This patch adds a conditional, and moves another up one level to remove the tab when it will have no content/effect To test: 1. Stage a MARC file from Tools > Stage MARC records for import 2. Go to Acquisitions and create a basket for a vendor 3. Add to basket from staged file 4. Note that the "item information" tab is present, if you click on it, not that it is not useful 5. Cancel adding to basket 6. Apply patch 7. Add to basket from the staged file again 8. Confirm there is no item information tab 9. Confirm orders are added on 'Save' Signed-off-by: David Nind <david@davidnind.com>
Created attachment 144730 [details] [review] Bug 20473: Whitespace Signed-off-by: David Nind <david@davidnind.com>
Testing notes (using KTD): 1. For step 2: When adding a basket to a vendor, for 'Create items when' select either 'receiving an order' or 'cataloging the record'.
Created attachment 145824 [details] [review] Bug 20473: Don't display 'Item information' tab when adding to basket from a file and not creating items This patch adds a conditional, and moves another up one level to remove the tab when it will have no content/effect To test: 1. Stage a MARC file from Tools > Stage MARC records for import 2. Go to Acquisitions and create a basket for a vendor 3. Add to basket from staged file 4. Note that the "item information" tab is present, if you click on it, not that it is not useful 5. Cancel adding to basket 6. Apply patch 7. Add to basket from the staged file again 8. Confirm there is no item information tab 9. Confirm orders are added on 'Save' Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 145825 [details] [review] Bug 20473: Whitespace Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to master for 23.05. Nice work everyone, thanks!
Nice work, thanks everyone! Pushed to 22.11.x for the next release.
Doesn't apply cleanly to 22.05.x, no backport.