Since bug 18570, sendmail is used directly from Passwordrecovery.t. We should mock it, like we do in Letters.t
Created attachment 73288 [details] [review] Bug 20474: Explicitly call sendmail to make mocking work
Created attachment 73289 [details] [review] Bug 20474: Mock sendmail instead of actually emailing Copy mocking sendmail code from t/db_dependent/Letters.t into the Passwordrecovery.t test file. prove t/db_dependent/Passwordrecovery.t
Created attachment 73322 [details] [review] Bug 20474: Explicitly call sendmail to make mocking work Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 73323 [details] [review] Bug 20474: Mock sendmail instead of actually emailing Copy mocking sendmail code from t/db_dependent/Letters.t into the Passwordrecovery.t test file. prove t/db_dependent/Passwordrecovery.t Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 73324 [details] [review] Bug 20474: Mimick Letters.t Please improve if needed the 2 occurrences on a separate bug reports. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Skipping QA to make Jenkins happy quickly.
Pushed to master for 18.05, thanks to everybody involved!
Awesome work all, backported to stable for 17.11.05