While testing Bug 20245, other issues were also discovered. See the following comment: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20245#c4
Created attachment 73361 [details] [review] Bug 20482: Correct Terminology codes to Bibliographic ones "RELATIONSHIP TO ISO 639-2 ISO 639-2 (Codes for the representation of names of languages-- Part 2: alpha-3 code) was based on the MARC Code List for Languages and published in 1998. In the 22 cases where the ISO 639-2 list has two alternative codes, the bibliographic code is the same as the MARC code." (http://www.loc.gov/marc/languages/introduction.pdf) This leads me to believe that eus, mri, and sqi are incorrect. The slk code was corrected on an earlier bug. TEST PLAN ---------- Apply patch Do a database upgrade -- Are eus, mri, and sqi fixed? reset_all -- Are eus, mri, and sqi never there in the first place? koha qa test tools only check perl code.
Created attachment 74654 [details] [review] Bug 20482: Correct Terminology codes to Bibliographic ones "RELATIONSHIP TO ISO 639-2 ISO 639-2 (Codes for the representation of names of languages-- Part 2: alpha-3 code) was based on the MARC Code List for Languages and published in 1998. In the 22 cases where the ISO 639-2 list has two alternative codes, the bibliographic code is the same as the MARC code." (http://www.loc.gov/marc/languages/introduction.pdf) This leads me to believe that eus, mri, and sqi are incorrect. The slk code was corrected on an earlier bug. TEST PLAN ---------- Apply patch Do a database upgrade -- Are eus, mri, and sqi fixed? reset_all -- Are eus, mri, and sqi never there in the first place? koha qa test tools only check perl code. Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Created attachment 74655 [details] [review] Bug 20482: (QA follow-up) Correct code in atomic update Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Trivial, passing QA
Pushed to master for 18.05, thanks to everybody involved!