Not a big deal, but one can access /cgi-bin/koha/admin/searchengine/elasticsearch/mappings.pl without the Elasticsearch Search engine preference enabled.
I think this is actually a feature. We should rename the page to 'Elasticsearch search configuartion' and have a note that it only applies to ES. This would allow users to tweak the ES settings before switching to Elasticsearch as their engine
Created attachment 102549 [details] [review] Bug 20484: Allow configuration of ES before switching to ES To test: 1 - Set SearchEngine syspref to Zebra 2 - Be a user with permission to manage search engine configuration (manage_search_engine_config) 3 - Confirm you do not see 'Search engine configuration' on Admin main page 4 - Apply patch 5 - Confirm you see it with '(Elasticsearch)' appended 6 - Be a user without above permission 7 - Confirm you cannot see the 'Search engine configuration' 8 - Confirm you cannot access directly: /cgi-bin/koha/admin/searchengine/elasticsearch/mappings.pl
Created attachment 102566 [details] [review] Bug 20484: Allow configuration of ES before switching to ES To test: 1 - Set SearchEngine syspref to Zebra 2 - Be a user with permission to manage search engine configuration (manage_search_engine_config) 3 - Confirm you do not see 'Search engine configuration' on Admin main page 4 - Apply patch 5 - Confirm you see it with '(Elasticsearch)' appended 6 - Be a user without above permission 7 - Confirm you cannot see the 'Search engine configuration' 8 - Confirm you cannot access directly: /cgi-bin/koha/admin/searchengine/elasticsearch/mappings.pl Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
You might want to take into account that not all modules have been installed when not using Elastic?? Could not compile /usr/share/koha/admin/searchengine/elasticsearch/mappings.pl: Can't locate Catmandu/Importer/MARC.pm in @INC (you may need to install the Catmandu::Importer::MARC module) (@INC contains: /usr/share/koha /usr/share/koha/installer /usr/share/koha/lib/installer /etc/perl /usr/local/lib/x86_64-linux-gnu/perl/5.24.1 /usr/local/share/perl/5.24.1 /usr/lib/x86_64-linux-gnu/perl5/5.24 /usr/share/perl5 /usr/lib/x86_64-linux-gnu/perl/5.24 /usr/share/perl/5.24 /usr/local/lib/site_perl /usr/lib/x86_64-linux-gnu/perl-base /var/lib/koha/master/plugins) at /usr/share/koha/Koha/SearchEngine/Elasticsearch/Indexer.pm line 28. BEGIN failed--compilation aborted at /usr/share/koha/Koha/SearchEngine/Elasticsearch/Indexer.pm line 28. Compilation failed in require at /usr/share/koha/admin/searchengine/elasticsearch/mappings.pl line 27. BEGIN failed--compilation aborted at /usr/share/koha/admin/searchengine/elasticsearch/mappings.pl line 27.
Created attachment 103195 [details] [review] Bug 20484: Allow configuration of ES before switching to ES To test: 1 - Set SearchEngine syspref to Zebra 2 - Be a user with permission to manage search engine configuration (manage_search_engine_config) 3 - Confirm you do not see 'Search engine configuration' on Admin main page 4 - Apply patch 5 - Confirm you see it with '(Elasticsearch)' appended 6 - Be a user without above permission 7 - Confirm you cannot see the 'Search engine configuration' 8 - Confirm you cannot access directly: /cgi-bin/koha/admin/searchengine/elasticsearch/mappings.pl Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Hm, missed Marcel's comment#4 - I will leave the status for now. Search engine configuration (Elasticsearch) is a bit long, wonder if we could discuss: Elasticsearch configuration as a title (next iteration, different bug).
Nice work everyone! Pushed to master for 20.05
Hmm.. I missed comment 4 too :(. I can either revert or preferably we could have a followup that adds a method to check if the required dependencies are installed?
Created attachment 103362 [details] [review] Bug 20484: Implement blocking_errors for ES config page
Backported to 19.11.x for 19.11.06
enhancement will not be backported to 19.05.x