There is no error checking on whether the barcode was found. Add some to prevent this internal server error. Can't call method "biblioitem" on an undefined value at /home/vagrant/kohaclone/C4/Circulation.pm line 673.
Created attachment 73439 [details] [review] Bug 20499: Unit Test to prove the problem TEST PLAN --------- 1) apply this patch 2) prove t/db_dependent/Circulation.t -- horrible death. 3) apply next path 4) prove t/db_dependent/Circulation.t -- passes. 5) run koha qa test tools
Created attachment 73440 [details] [review] Bug 20499: Fix the Internal Server Error TEST PLAN --------- See comment #1 Applying the test without the patch: messy. Applyin both patches: smooth. Run koha qa test tools
The location of the test was chosen, because it is where the first occurrence of CanBookBeIssued is. Feel free to move it elsewhere if needed. But the fix is the fix. :)
Created attachment 73442 [details] [review] Bug 20499: Fix the Internal Server Error TEST PLAN --------- See comment #1 Applying the test without the patch: messy. Applyin both patches: smooth. Run koha qa test tools
Caused by commit 6183c0e6a910663fec02bdba66d05f173310f562 Bug 19943: Koha::Biblio - Replace GetBiblioItemData with Koha::Biblio->biblioitem
Created attachment 74107 [details] [review] Bug 20499: Unit Test to prove the problem TEST PLAN --------- 1) apply this patch 2) prove t/db_dependent/Circulation.t -- horrible death. 3) apply next path 4) prove t/db_dependent/Circulation.t -- passes. 5) run koha qa test tools Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 74108 [details] [review] Bug 20499: Fix the Internal Server Error TEST PLAN --------- See comment #1 Applying the test without the patch: messy. Applyin both patches: smooth. Run koha qa test tools Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 74109 [details] [review] Bug 20499: just check if GetItem returns something is enough Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
QA: Looking here
'"KohaIsAwesome" is not a valid barcode. Mark: Formally, this is an assumption :)
Created attachment 74144 [details] [review] Bug 20499: Unit Test to prove the problem TEST PLAN --------- 1) apply this patch 2) prove t/db_dependent/Circulation.t -- horrible death. 3) apply next path 4) prove t/db_dependent/Circulation.t -- passes. 5) run koha qa test tools Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Created attachment 74145 [details] [review] Bug 20499: Fix the Internal Server Error TEST PLAN --------- See comment #1 Applying the test without the patch: messy. Applyin both patches: smooth. Run koha qa test tools Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Created attachment 74146 [details] [review] Bug 20499: just check if GetItem returns something is enough Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Pushed to master for 18.05, thanks to everybody involved!
Dependency not in stable