When using a cover source other than Amazon (which uses static links) the shelf browser does not fire a call to the image sources when moving to a new page To recreate: Enable coce (https://coce.bywatersolutions.com) and enable all sources except amazon Enable shelf browser View a title in the opac View the shelf browser, note images load on first page Page left or right and note images are not loaded
Created attachment 76436 [details] [review] Bug 20507: Shelf browser does not update image sources when paging This patch updates the shelfbrowser include so that the system preference check for Coce will function correctly. To test, apply the patch and test the OPAC shelf browser with each of the enhanced content options enabled: Coce, Amazon, Google. In each case, page through the shelf browser to confirm that covers load correctly.
(In reply to Owen Leonard from comment #1) > Created attachment 76436 [details] [review] [review] > Bug 20507: Shelf browser does not update image sources when paging > > This patch updates the shelfbrowser include so that the system > preference check for Coce will function correctly. > > To test, apply the patch and test the OPAC shelf browser with each of > the enhanced content options enabled: Coce, Amazon, Google. In each > case, page through the shelf browser to confirm that covers load > correctly. The patch seemed to work fine in Sandbox 06, clearing the cache for each content option. Several items had covers missing, but these all appeared to titles for which no covers were available in the first place.
Hi Cab, you can also mark the patch as signed off from the sandboxes by using the form at the bottom. We can add your name in QA for this one, maybe for your next!
(In reply to Katrin Fischer from comment #3) > Hi Cab, you can also mark the patch as signed off from the sandboxes by > using the form at the bottom. We can add your name in QA for this one, maybe > for your next! OK, thank you, Katrin. Was thinking I should post on BugZilla, where it's just as easy to update the status. But that's probably not necessary ...
(In reply to Cab Vinton from comment #4) > (In reply to Katrin Fischer from comment #3) > > Hi Cab, you can also mark the patch as signed off from the sandboxes by > > using the form at the bottom. We can add your name in QA for this one, maybe > > for your next! > > OK, thank you, Katrin. Was thinking I should post on BugZilla, where it's > just as easy to update the status. But that's probably not necessary ... Setting the status is alright, but using the sign-off feature will also add your name as a sign-off to the patches, which will make your name go into release notes etc.
... also your sign-offs made my day, thx! :)
Ah, gotcha. Excellent. The tutorial video was helpful. Think developers should add a code to the bugs needing Sign Offs -- TBAI (Testable by Any Idiot) ;-) With several hundred bugs, it can take some time to identify the ones that don't require CLI access, don't have too many moving parts, etc. Not complaining by any means, but it might increase the number of bugs that get signed off by everyday librarians, which should be a good thing.
Created attachment 76718 [details] [review] Bug 20507: Shelf browser does not update image sources when paging This patch updates the shelfbrowser include so that the system preference check for Coce will function correctly. To test, apply the patch and test the OPAC shelf browser with each of the enhanced content options enabled: Coce, Amazon, Google. In each case, page through the shelf browser to confirm that covers load correctly. Signed-off-by: Cab Vinton <bibliwho@gmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
(In reply to Cab Vinton from comment #7) > Ah, gotcha. > > Excellent. The tutorial video was helpful. Excellent? But I still had to add your signoff line ;) Would you not forget next time ?
Awesome work all! Pushed to master for 18.11
Pushed to 18.05.x for 18.05.02
Pushed to 17.11.x for 17.11.08