Use of uninitialized value $template_type in string eq at /home/vagrant/kohaclone/catalogue/search.pl line 273. Use of uninitialized value $limit_cgi in split at /home/vagrant/kohaclone/catalogue/search.pl line 496. Use of uninitialized value $total in addition (+) at /home/vagrant/kohaclone/catalogue/search.pl line 541. Use of uninitialized value $limit_cgi_not_availablity in substitution (s///) at /home/vagrant/kohaclone/catalogue/search.pl line 590. Use of uninitialized value $gotonumber in string eq at /home/vagrant/kohaclone/catalogue/search.pl line 706. Use of uninitialized value $gotonumber in string eq at /home/vagrant/kohaclone/catalogue/search.pl line 706. Use of uninitialized value $gotopage in pattern match (m//) at /home/vagrant/kohaclone/catalogue/search.pl line 711.
Created attachment 73849 [details] [review] Bug 20539: Remove warnings in catalogue/search.pl Test plan: 1. Start a search from intranet 2. See several warnings in logs 3. Apply patch (&& reload starman) 4. Start a new search 5. Confirm that warnings are gone and that the search still works
Created attachment 74176 [details] [review] Bug 20539: Remove warnings in catalogue/search.pl Test plan: 1. Start a search from intranet 2. See several warnings in logs 3. Apply patch (&& reload starman) 4. Start a new search 5. Confirm that warnings are gone and that the search still works Signed-off-by: Roch D'Amour <roch.damour@inlibro.com>
Created attachment 74181 [details] [review] Bug 20539: Remove warnings in catalogue/search.pl Test plan: 1. Start a search from intranet 2. See several warnings in logs 3. Apply patch (&& reload starman) 4. Start a new search 5. Confirm that warnings are gone and that the search still works Signed-off-by: Roch D'Amour <roch.damour@inlibro.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Pushed to master for 18.05, thanks to everybody involved!
Cannot recreate in 17.11