A suggestion for updating the OPAC CSS
Created attachment 73941 [details] [review] Bug 20554: New OPAC CSS A suggestion for updating the OPAC CSS This patch updates the css styling of the OPAC
Created attachment 73942 [details] [review] Bug 20554: (follow-up) Compiled CSS This patch includes the compiled CSS.
Created attachment 74090 [details] [review] Bug 20554: New OPAC CSS A suggestion for updating the OPAC CSS This patch updates the css styling of the OPAC
Created attachment 74091 [details] [review] Bug 20554: (follow-up) Compiled CSS This patch includes the compiled CSS.
Can I have a test plan so I can sign off your bug?
Woops! I tried applying to patch and take a look at it, but it didn't apply. I got a sha1 error : .git/rebase-apply/patch:32: trailing whitespace. font-family: 'NotoSansRegular'; .git/rebase-apply/patch:315: trailing whitespace. font-family: 'NotoSansRegular'; .git/rebase-apply/patch:342: trailing whitespace. .git/rebase-apply/patch:362: trailing whitespace. } .git/rebase-apply/patch:495: trailing whitespace. } fatal: sha1 information is lacking or useless (koha-tmpl/opac-tmpl/bootstrap/css/src/_responsive.scss). error: could not build fake ancestor
Created attachment 74656 [details] [review] Bug 20554: (follow-up) Add local font files and add method for loading them This patch adds local copies of the font files specified in the original patch. A new JavaScript file has been added, fontfaceobserver.min.js, which helps gracefully load font assets. https://github.com/bramstein/fontfaceobserver Information about the new assets has been added to the about page. When using web fonts, there can be a delay, while the browser loads the font files, between the time the page loads and the time the fonts render. Font Face Observer allows us to specify a default font for the initial page render, and then apply the web font after it has loaded. To test, apply the patch and regenerate the OPAC css. View any page in the OPAC and confirm that the custom font renders properly. View the About page in the staff client and confirm that the new license information looks correct.
Created attachment 74657 [details] [review] Bug 20554: (follow-up) Compiled CSS This patch includes the compiled CSS.
Created attachment 74715 [details] [review] Bug 20554: New OPAC CSS A suggestion for updating the OPAC CSS This patch updates the css styling of the OPAC
Created attachment 74716 [details] [review] Bug 20554: (follow-up) Add local font files and add method for loading them This patch adds local copies of the font files specified in the original patch. A new JavaScript file has been added, fontfaceobserver.min.js, which helps gracefully load font assets. https://github.com/bramstein/fontfaceobserver Information about the new assets has been added to the about page. When using web fonts, there can be a delay, while the browser loads the font files, between the time the page loads and the time the fonts render. Font Face Observer allows us to specify a default font for the initial page render, and then apply the web font after it has loaded. To test, apply the patch and regenerate the OPAC css. View any page in the OPAC and confirm that the custom font renders properly. View the About page in the staff client and confirm that the new license information looks correct.
Created attachment 74717 [details] [review] Bug 20554: (follow-up) Compiled CSS This patch includes the compiled CSS.
Created attachment 76523 [details] [review] Bug 20554: (follow-up) Add local font files and add method for loading them This patch adds local copies of the font files specified in the original patch. A new JavaScript file has been added, fontfaceobserver.min.js, which helps gracefully load font assets. https://github.com/bramstein/fontfaceobserver Information about the new assets has been added to the about page. When using web fonts, there can be a delay, while the browser loads the font files, between the time the page loads and the time the fonts render. Font Face Observer allows us to specify a default font for the initial page render, and then apply the web font after it has loaded. To test, apply the patch and regenerate the OPAC css. View any page in the OPAC and confirm that the custom font renders properly. View the About page in the staff client and confirm that the new license information looks correct.
Created attachment 76524 [details] [review] Bug 20554: (follow-up) Compiled CSS This patch includes the compiled CSS.
Created attachment 77689 [details] [review] Bug 20554: New OPAC CSS A suggestion for updating the OPAC CSS This patch updates the css styling of the OPAC
Created attachment 77690 [details] [review] Bug 20554: (follow-up) Add local font files and add method for loading them This patch adds local copies of the font files specified in the original patch. A new JavaScript file has been added, fontfaceobserver.min.js, which helps gracefully load font assets. https://github.com/bramstein/fontfaceobserver Information about the new assets has been added to the about page. When using web fonts, there can be a delay, while the browser loads the font files, between the time the page loads and the time the fonts render. Font Face Observer allows us to specify a default font for the initial page render, and then apply the web font after it has loaded. To test, apply the patch and regenerate the OPAC css. View any page in the OPAC and confirm that the custom font renders properly. View the About page in the staff client and confirm that the new license information looks correct.
Created attachment 77906 [details] Screenshot of the OPAC homepage
Created attachment 77907 [details] Screenshot of the OPAC Results list
Created attachment 77908 [details] Screenshot of the OPAC drop down menu
Created attachment 77909 [details] Screenshot of the OPAC detail page
Created attachment 77913 [details] Screenshot of the borrower account fines tab
I've just run into issues trying to apply this patch too :/ vagrant@kohadevbox:kohaclone(master)$ git bz apply -s 20554 Bug 20554 - New OPAC CSS 77689 - Bug 20554: New OPAC CSS 77690 - Bug 20554: (follow-up) Add local font files and add method for loading them Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 20554: New OPAC CSS Using index info to reconstruct a base tree... M koha-tmpl/opac-tmpl/bootstrap/en/includes/doc-head-close.inc Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/opac-tmpl/bootstrap/en/includes/doc-head-close.inc Applying: Bug 20554: (follow-up) Add local font files and add method for loading them Using index info to reconstruct a base tree... M koha-tmpl/intranet-tmpl/prog/en/modules/about.tt M koha-tmpl/opac-tmpl/bootstrap/en/includes/doc-head-close.inc M koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-bottom.inc Falling back to patching base and 3-way merge... error: The following untracked working tree files would be overwritten by merge: koha-tmpl/opac-tmpl/bootstrap/css/fonts/NotoSans-Bold-webfont.woff koha-tmpl/opac-tmpl/bootstrap/css/fonts/NotoSans-Bold-webfont.woff2 koha-tmpl/opac-tmpl/bootstrap/css/fonts/NotoSans-BoldItalic-webfont.woff koha-tmpl/opac-tmpl/bootstrap/css/fonts/NotoSans-BoldItalic-webfont.woff2 koha-tmpl/opac-tmpl/bootstrap/css/fonts/NotoSans-Italic-webfont.woff koha-tmpl/opac-tmpl/bootstrap/css/fonts/NotoSans-Italic-webfont.woff2 koha-tmpl/opac-tmpl/bootstrap/css/fonts/NotoSans-Regular-webfont.woff koha-tmpl/opac-tmpl/bootstrap/css/fonts/NotoSans-Regular-webfont.woff2 koha-tmpl/opac-tmpl/bootstrap/lib/fontfaceobserver.min.js Please move or remove them before you can merge. Aborting Failed to merge in the changes. Patch failed at 0001 Bug 20554: (follow-up) Add local font files and add method for loading them The copy of the patch that failed is found in: /home/vagrant/kohaclone/.git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-20554-follow-up-Add-local-font-files-and-add-m-Hfq677.patch
Created attachment 78257 [details] [review] Bug 20554: New OPAC CSS A suggestion for updating the OPAC CSS This patch updates the css styling of the OPAC
Created attachment 78258 [details] [review] Bug 20554: (follow-up) Add local font files and add method for loading them This patch adds local copies of the font files specified in the original patch. A new JavaScript file has been added, fontfaceobserver.min.js, which helps gracefully load font assets. https://github.com/bramstein/fontfaceobserver Information about the new assets has been added to the about page. When using web fonts, there can be a delay, while the browser loads the font files, between the time the page loads and the time the fonts render. Font Face Observer allows us to specify a default font for the initial page render, and then apply the web font after it has loaded. To test, apply the patch and regenerate the OPAC css. View any page in the OPAC and confirm that the custom font renders properly. View the About page in the staff client and confirm that the new license information looks correct.
Created attachment 78360 [details] [review] Bug 20554: (follow-up) Add local font files and add method for loading them This patch adds local copies of the font files specified in the original patch. A new JavaScript file has been added, fontfaceobserver.min.js, which helps gracefully load font assets. https://github.com/bramstein/fontfaceobserver Information about the new assets has been added to the about page. When using web fonts, there can be a delay, while the browser loads the font files, between the time the page loads and the time the fonts render. Font Face Observer allows us to specify a default font for the initial page render, and then apply the web font after it has loaded. To test, apply the patch and regenerate the OPAC css. View any page in the OPAC and confirm that the custom font renders properly. View the About page in the staff client and confirm that the new license information looks correct. Patch applies and OPAC and license look good. Looking forward to this. Signed-off-by: Dilan Johnpullé <dilan@calyx.net.au>
Does no longer apply. Can you detail the different changes we are suppose to see?
Created attachment 78666 [details] [review] Bug 20554: New OPAC CSS A suggestion for updating the OPAC CSS This patch updates the css styling of the OPAC
Created attachment 78667 [details] [review] Bug 20554: (follow-up) Add local font files and add method for loading them This patch adds local copies of the font files specified in the original patch. A new JavaScript file has been added, fontfaceobserver.min.js, which helps gracefully load font assets. https://github.com/bramstein/fontfaceobserver Information about the new assets has been added to the about page. When using web fonts, there can be a delay, while the browser loads the font files, between the time the page loads and the time the fonts render. Font Face Observer allows us to specify a default font for the initial page render, and then apply the web font after it has loaded. To test, apply the patch and regenerate the OPAC css. View any page in the OPAC and confirm that the custom font renders properly. View the About page in the staff client and confirm that the new license information looks correct. Patch applies and OPAC and license look good. Looking forward to this. Signed-off-by: Dilan Johnpullé <dilan@calyx.net.au>
Padding should be removed for mobile views.
Created attachment 78730 [details] [review] Bug 20554: (QA follow up) Remove padding in mobile view This patch removes the padding for mobile screen sizes. https://bugs.koha-community.org/show_bug.cgi?id=20054
Created attachment 78731 [details] [review] Bug 20554: (QA follow up) Remove padding in mobile view This patch removes the padding for mobile screen sizes.
Created attachment 78811 [details] [review] Bug 20554: New OPAC CSS A suggestion for updating the OPAC CSS This patch updates the css styling of the OPAC Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 78813 [details] [review] Bug 20554: (follow-up) Add local font files and add method for loading them This patch adds local copies of the font files specified in the original patch. A new JavaScript file has been added, fontfaceobserver.min.js, which helps gracefully load font assets. https://github.com/bramstein/fontfaceobserver Information about the new assets has been added to the about page. When using web fonts, there can be a delay, while the browser loads the font files, between the time the page loads and the time the fonts render. Font Face Observer allows us to specify a default font for the initial page render, and then apply the web font after it has loaded. To test, apply the patch and regenerate the OPAC css. View any page in the OPAC and confirm that the custom font renders properly. View the About page in the staff client and confirm that the new license information looks correct. Patch applies and OPAC and license look good. Looking forward to this. Signed-off-by: Dilan Johnpullé <dilan@calyx.net.au> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 78814 [details] [review] Bug 20554: (QA follow up) Remove padding in mobile view This patch removes the padding for mobile screen sizes. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Works as expected. IMO it's too bright, but we could get more opinions once pushed ;)
(In reply to Jonathan Druart from comment #34) > Works as expected. IMO it's too bright, but we could get more opinions once > pushed ;) Haha, there's always someone wanting a 'Dark theme'. I too would appreciate an enhancement that allowed basic colour scheme selection allowing the end user to select between 'light' and 'dark' modes (or for the accesablity minded amongst us a 'high contrast' mode?)
I would appreciate a high contrast mode. The screen shots are low resolution, but even still, I'd prefer strong contrast and ease of reading over cosmetic changes.
I'm afraid I can't get this to apply against master now :(
Created attachment 79905 [details] [review] Bug 20554: New OPAC CSS A suggestion for updating the OPAC CSS This patch updates the css styling of the OPAC Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 79906 [details] [review] Bug 20554: (follow-up) Add local font files and add method for loading them This patch adds local copies of the font files specified in the original patch. A new JavaScript file has been added, fontfaceobserver.min.js, which helps gracefully load font assets. https://github.com/bramstein/fontfaceobserver Information about the new assets has been added to the about page. When using web fonts, there can be a delay, while the browser loads the font files, between the time the page loads and the time the fonts render. Font Face Observer allows us to specify a default font for the initial page render, and then apply the web font after it has loaded. To test, apply the patch and regenerate the OPAC css. View any page in the OPAC and confirm that the custom font renders properly. View the About page in the staff client and confirm that the new license information looks correct. Patch applies and OPAC and license look good. Looking forward to this. Signed-off-by: Dilan Johnpullé <dilan@calyx.net.au> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 79907 [details] [review] Bug 20554: (QA follow up) Remove padding in mobile view This patch removes the padding for mobile screen sizes. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
I'm afraid I'm not sure that rebase worked well.. I'm getting some very odd display now, not much like the screenshots attached here at all. I ran the `yarn build --view opac` command and restarted memcached and apache (not a plack install here).. is there anything I'm missing ?
After some investigation it seems ` OpacAdditionalStylesheet ` must contain ` opac.css ` for this patch to work.. is that expected?
Please rebase :-)
Created attachment 80742 [details] [review] Bug 20554: New OPAC CSS A suggestion for updating the OPAC CSS This patch updates the css styling of the OPAC Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 80743 [details] [review] Bug 20554: (follow-up) Add local font files and add method for loading them This patch adds local copies of the font files specified in the original patch. A new JavaScript file has been added, fontfaceobserver.min.js, which helps gracefully load font assets. https://github.com/bramstein/fontfaceobserver Information about the new assets has been added to the about page. When using web fonts, there can be a delay, while the browser loads the font files, between the time the page loads and the time the fonts render. Font Face Observer allows us to specify a default font for the initial page render, and then apply the web font after it has loaded. To test, apply the patch and regenerate the OPAC css. View any page in the OPAC and confirm that the custom font renders properly. View the About page in the staff client and confirm that the new license information looks correct. Patch applies and OPAC and license look good. Looking forward to this. Signed-off-by: Dilan Johnpullé <dilan@calyx.net.au> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 80744 [details] [review] Bug 20554: (QA follow up) Remove padding in mobile view This patch removes the padding for mobile screen sizes. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Awesome work all! Pushed to master for 18.11
Created attachment 81067 [details] [review] Bug 20554: (follow-up) KOHA_VERSION is not needed in opaclayoutstylesheet SET opaclayoutstylesheet does not need KOHA_VERSION, its defined by Asset.css()
Created attachment 81068 [details] [review] Bug 20554: (follow-up) KOHA_VERSION is not needed in opaclayoutstylesheet SET opaclayoutstylesheet does not need KOHA_VERSION, its defined by Asset.css() Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Fix a bad resolution conflict
(In reply to Jonathan Druart from comment #49) > Created attachment 81068 [details] [review] [review] > Bug 20554: (follow-up) KOHA_VERSION is not needed in opaclayoutstylesheet > > SET opaclayoutstylesheet does not need KOHA_VERSION, its defined by > Asset.css() > > Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> > Fix a bad resolution conflict Followup pushed to master for 18.11, thanks Frido!
Enhancement will not be backported to 18.05.x series.
Hi everyone, unfortunately the self-checkout module has been neglected/missed again and the nice new theme isn't yet applied to it, leading to an inconsistent UI. What's the easiest way to fix that? Cheers
(In reply to Oliver Behnke from comment #52) > Hi everyone, unfortunately the self-checkout module has been > neglected/missed again and the nice new theme isn't yet applied to it, > leading to an inconsistent UI. What's the easiest way to fix that? > > Cheers Please file a new bug :) (see my other comment)
Done
By the way, fontfaceobserver.min.js is getting flagged as the Miner.Jswebcoin virus by Symantec Endpoint Protection. It says that Symantec have had it flagged for more than 1 year, and that the file is untrustworthy. I have examined the Javascript, and it really appears to be a false positive, but I'm noting it here anyway. I'm going to look at removing fontfaceobserver locally so that it can pass security checks for the time being.
(In reply to David Cook from comment #55) > By the way, fontfaceobserver.min.js is getting flagged as the > Miner.Jswebcoin virus by Symantec Endpoint Protection. > > It says that Symantec have had it flagged for more than 1 year, and that the > file is untrustworthy. > > I have examined the Javascript, and it really appears to be a false > positive, but I'm noting it here anyway. > > I'm going to look at removing fontfaceobserver locally so that it can pass > security checks for the time being. Hi David, if we need to do something about this, please file a new bug report.
(In reply to Katrin Fischer from comment #56) > (In reply to David Cook from comment #55) > > By the way, fontfaceobserver.min.js is getting flagged as the > > Miner.Jswebcoin virus by Symantec Endpoint Protection. > > > > It says that Symantec have had it flagged for more than 1 year, and that the > > file is untrustworthy. > > > > I have examined the Javascript, and it really appears to be a false > > positive, but I'm noting it here anyway. > > > > I'm going to look at removing fontfaceobserver locally so that it can pass > > security checks for the time being. > > Hi David, if we need to do something about this, please file a new bug > report. At this point, I'm still waiting to hear back from Symantec. I'm hoping that they'll check this out, and update their virus definitions to no longer include fontfaceobserver. Locally, we've disabled fontfaceobserver for those using Symantec Endpoint Protection, so that they don't get the virus alert anymore. But I don't think there's anything that needs to be done on the Koha community side of things at this point. Just giving people a FYI.