Bug 20584 - Koha/Patron/Categories.t is failing on slow servers
Summary: Koha/Patron/Categories.t is failing on slow servers
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Test Suite (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low minor (vote)
Assignee: Jonathan Druart
QA Contact: Testopia
URL:
Keywords:
Depends on: 19176
Blocks: 25551
  Show dependency treegraph
 
Reported: 2018-04-13 18:09 UTC by Jonathan Druart
Modified: 2020-05-20 12:26 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 20584: Prevent Koha/Patron/Categories.t to fail randomly (2.28 KB, patch)
2018-04-13 18:11 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2018-04-13 18:09:33 UTC
https://jenkins.koha-community.org/job/Koha_Master_D8/433/consoleFull

koha_1       |     #   Failed test 'With enrolmentperiod defined and no parameter, ->get_expiry_date should return today + enrolmentperiod'
koha_1       |     #   at t/db_dependent/Koha/Patron/Categories.t line 78.
koha_1       |     #          got: '2019-04-13T17:30:30'
koha_1       |     #     expected: '2019-04-13T17:30:29'
koha_1       |     # Looks like you failed 1 test of 5.
koha_1       | 
koha_1       | #   Failed test 'get_expiry_date'
koha_1       | #   at t/db_dependent/Koha/Patron/Categories.t line 85.
koha_1       | # Looks like you failed 1 test of 10.
koha_1       | [17:30:30] t/db_dependent/Koha/Patron/Categories.t ........................
Comment 1 Jonathan Druart 2018-04-13 18:11:13 UTC
Created attachment 74175 [details] [review]
Bug 20584: Prevent Koha/Patron/Categories.t to fail randomly

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 2 Jonathan Druart 2018-04-13 18:11:42 UTC
Pushed to master for 18.05
Comment 3 Nick Clemens 2018-05-22 11:06:16 UTC
Pushed to stable for 17.11.6
Comment 4 Fridolin Somers 2018-05-23 05:06:21 UTC
I prefer not to push to this one and Bug 19176 on 17.05.x
Comment 5 Jonathan Druart 2018-05-23 13:38:12 UTC
(In reply to Fridolin SOMERS from comment #4)
> I prefer not to push to this one and Bug 19176 on 17.05.x

Why that? It only affects tests and will prevent random failures.
Comment 6 Fridolin Somers 2018-05-24 13:46:05 UTC
(In reply to Jonathan Druart from comment #5)
> (In reply to Fridolin SOMERS from comment #4)
> > I prefer not to push to this one and Bug 19176 on 17.05.x
> 
> Why that? It only affects tests and will prevent random failures.

Bug 19176 is complex, I want to stabilize 17.05.x and focus on 17.11.x soon.