To test: - create a subscrpition - go to the serials collection page - don't check any checkboxes for serials - click 'Edit serials' There will be an internal server error: Use of uninitialized value $serstatus in split at /home/vagrant/kohaclone/serials/serials-edit.pl line 100. Can't call method "title" on an undefined value at /home/vagrant/kohaclone/serials/serials-edit.pl line 423.
Created attachment 74766 [details] [review] Bug 20616: Prevent "edit serials" form submission if no serial is selected In order to prevent the form to submit and gives an ugly error if no issues are selected we will make sure at least one is checked otherwise an alert will be displayed. Test plan: - create a subscrpition - go to the serials collection page - don't check any checkboxes for serials - click 'Edit serials'
Created attachment 74768 [details] [review] Bug 20616: Prevent "edit serials" form submission if no serial is selected In order to prevent the form to submit and gives an ugly error if no issues are selected we will make sure at least one is checked otherwise an alert will be displayed. Test plan: - create a subscrpition - go to the serials collection page - don't check any checkboxes for serials - click 'Edit serials' Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr>
Warning popup is better than an error page :) Thank you Cait !
It was Jonathan's work :)
Created attachment 74772 [details] [review] Bug 20616: Prevent "edit serials" form submission if no serial is selected In order to prevent the form to submit and gives an ugly error if no issues are selected we will make sure at least one is checked otherwise an alert will be displayed. Test plan: - create a subscrpition - go to the serials collection page - don't check any checkboxes for serials - click 'Edit serials' Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 74773 [details] [review] Bug 20616: (QA follow-up) Make alert translatable
(In reply to Katrin Fischer from comment #4) > It was Jonathan's work :) oups... Thank you Cait for pointing this issue, and Jonathan for solving it ! You're a great team.
Pushed to master for 18.05, thanks to everybody involved!
Pushed to 17.11.x for 17.11.11