Created attachment 74530 [details] Missing link for Search engine configuration On the #navmenulist of the different administration pages, link to 'Search engine configuration' menu is missing (should be under 'Item search fileds' link). It should be displayed only if the 'Searchengine' preference is set on 'ElasticSearch' (just like the menu on /admin/admin-home.pl).
Created attachment 74658 [details] [review] Bug 20617: Add 'Search Engine configuration' link to administration menu This patch adds a link to the Elasticsearch configuration page in the administration sidebar menu when Elasticsearch is enabled. This patch also corrects the title of the Elasticsearch page to match the page heading. "Search engine configuration" instead of "Elasticsearch mappings." To test, apply the patch and set the SearchEngine system preference to "Elasticsearch." - View any page in the administration module which shows the left-hand sidebar menu. The link to search engine configuration should be there. - View the search engine configuration page and confirm that the page title is correct. - Set the SearchEngine system preferenc to "Zebra." - The search engine configuration link should no longer appear in the administration sidebar menu.
Created attachment 74665 [details] [review] Bug 20617: Add 'Search Engine configuration' link to administration menu This patch adds a link to the Elasticsearch configuration page in the administration sidebar menu when Elasticsearch is enabled. This patch also corrects the title of the Elasticsearch page to match the page heading. "Search engine configuration" instead of "Elasticsearch mappings." To test, apply the patch and set the SearchEngine system preference to "Elasticsearch." - View any page in the administration module which shows the left-hand sidebar menu. The link to search engine configuration should be there. - View the search engine configuration page and confirm that the page title is correct. - Set the SearchEngine system preferenc to "Zebra." - The search engine configuration link should no longer appear in the administration sidebar menu. Signed-off-by: David Bourgault <david.bourgault@inlibro.com>
Created attachment 74669 [details] [review] Bug 20617: Add 'Search Engine configuration' link to administration menu This patch adds a link to the Elasticsearch configuration page in the administration sidebar menu when Elasticsearch is enabled. This patch also corrects the title of the Elasticsearch page to match the page heading. "Search engine configuration" instead of "Elasticsearch mappings." To test, apply the patch and set the SearchEngine system preference to "Elasticsearch." - View any page in the administration module which shows the left-hand sidebar menu. The link to search engine configuration should be there. - View the search engine configuration page and confirm that the page title is correct. - Set the SearchEngine system preferenc to "Zebra." - The search engine configuration link should no longer appear in the administration sidebar menu. Signed-off-by: David Bourgault <david.bourgault@inlibro.com> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr>
Thanks Owen, it works as described ! Just a naive question left : (In reply to Owen Leonard from comment #1) > This patch also corrects the title of the Elasticsearch page to match > the page heading. "Search engine configuration" instead of > "Elasticsearch mappings." That's a good idea, but as it only concerns Elasticsearch configuration, why do you prefer to keep "Search engine configuration" instead of "Elasticsearch configuration" ?
(In reply to Séverine Queune from comment #4) > That's a good idea, but as it only concerns Elasticsearch configuration, why > do you prefer to keep "Search engine configuration" instead of > "Elasticsearch configuration" ? I wasn't sure which to go with for the same reason. I chose to match the existing page heading because I think "Search engine configuration" is a more user-friendly description. I assume that once Elasticsearch is enabled the librarian/administrator doesn't need to know they're configuring Elasticsearch. They only need to configure "the search engine."
Created attachment 74708 [details] [review] Bug 20617: Add 'Search Engine configuration' link to administration menu This patch adds a link to the Elasticsearch configuration page in the administration sidebar menu when Elasticsearch is enabled. This patch also corrects the title of the Elasticsearch page to match the page heading. "Search engine configuration" instead of "Elasticsearch mappings." To test, apply the patch and set the SearchEngine system preference to "Elasticsearch." - View any page in the administration module which shows the left-hand sidebar menu. The link to search engine configuration should be there. - View the search engine configuration page and confirm that the page title is correct. - Set the SearchEngine system preferenc to "Zebra." - The search engine configuration link should no longer appear in the administration sidebar menu. Signed-off-by: David Bourgault <david.bourgault@inlibro.com> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
(In reply to Owen Leonard from comment #5) > (In reply to Séverine Queune from comment #4) > > > That's a good idea, but as it only concerns Elasticsearch configuration, why > > do you prefer to keep "Search engine configuration" instead of > > "Elasticsearch configuration" ? > > I wasn't sure which to go with for the same reason. I chose to match the > existing page heading because I think "Search engine configuration" is a > more user-friendly description. > > I assume that once Elasticsearch is enabled the librarian/administrator > doesn't need to know they're configuring Elasticsearch. They only need to > configure "the search engine." Your logic makes sense, I'm ok with it :)
Pushed to master for 18.05, thanks to everybody involved!