Created attachment 74731 [details] It shows the two item types combined. The screenshot shows the two item types combined. The issue is in the dropdown menu.
Follow up of https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19972#c4 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19972#c8
Created attachment 74821 [details] [review] Bug 20637: Fix filters content on the holds to pull screen libraries and locations are separated by <br> whereas itypes are using \n This patch standardized the separator to generate correctly the filters pulldown Test plan: - Place a hold on a biblio record which has several items - Define different location and itypes for these items - Display the hold on the "Holds to pull" screen and make sure the filters are working correctly (focus on the dropdown list)
Created attachment 74881 [details] [review] Bug 20637: Fix filters content on the holds to pull screen libraries and locations are separated by <br> whereas itypes are using \n This patch standardized the separator to generate correctly the filters pulldown Test plan: - Place a hold on a biblio record which has several items - Define different locations and itypes for these items - Display the holds on the "Holds to pull" screen and make sure the filters are working correctly (focus on the dropdown list) Signed-off-by: Victor Grousset <victor.grousset@biblibre.com>
itypes got fixed and no regressions on libraries and locations. Works great, thanks!
Created attachment 74927 [details] [review] Bug 20637: Fix filters content on the holds to pull screen libraries and locations are separated by <br> whereas itypes are using \n This patch standardized the separator to generate correctly the filters pulldown Test plan: - Place a hold on a biblio record which has several items - Define different locations and itypes for these items - Display the holds on the "Holds to pull" screen and make sure the filters are working correctly (focus on the dropdown list) Signed-off-by: Victor Grousset <victor.grousset@biblibre.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to master for 18.05, thanks to everybody involved!