Steps to reproduce: Advanced Search Choose an Item type (do not enter any other search limits) Search Click on Sort (it doesn't appear to matter what you sort on) The results don't sort. I did notice that the URL changes and a string of %20s follows the sort_by= For example: sort_by=title_az%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20&limit=mc-itype,phr:62 If I cut the %20s out of the URL and load it, then the sorted results appear.
Certainly caused by commit 7d2cb42dceeeb004ab7447fd6beccab5fac37e23 Bug 19461: Add floating toolbar to staff client catalog search results
Created attachment 74822 [details] [review] Bug 20652: Fix result sorting after search on limit only 1 chomp was missing, spaces were replaced with %20 This patch adds extra chomps, but it does not hurt Test plan: Advanced Search Choose an Item type (do not enter any other search limits) Search Click on Sort (it doesn't appear to matter what you sort on)
Created attachment 75571 [details] [review] Bug 20652: Fix result sorting after search on limit only 1 chomp was missing, spaces were replaced with %20 This patch adds extra chomps, but it does not hurt Test plan: Advanced Search Choose an Item type (do not enter any other search limits) Search Click on Sort (it doesn't appear to matter what you sort on) Signed-off-by: Pierre-Luc Lapointe <pierreluc.lapointe@inLibro.com>
Created attachment 75581 [details] [review] Bug 20652: Fix result sorting after search on limit only 1 chomp was missing, spaces were replaced with %20 This patch adds extra chomps, but it does not hurt Test plan: Advanced Search Choose an Item type (do not enter any other search limits) Search Click on Sort (it doesn't appear to matter what you sort on) Signed-off-by: Pierre-Luc Lapointe <pierreluc.lapointe@inLibro.com> Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Pushed to master for 18.11. Awesome work all, thank you.
This patch has been pushed to 18.05.x, will be in 18.05.01
Pushed to 17.11.x for 17.11.07
Bug 19461 not in 17.05.x