git grep "Create Compound Report" only generates one matching line in guided reports. It makes no sense to keep this dead code and the code which it would trigger.
Created attachment 74871 [details] [review] Bug 20663: Remove dead code related to compound reports TEST PLAN --------- git grep "Create Compound Report" -- only one file git grep compound | grep 1 -- this is the only setting of the compound tt variable less koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt -- There is an TT IF statement for compound. -- In that statement it would trigger 'Save Compound' git grep save_compound -- only the template and the guided report perl git grep create_compound -- only triggered by the save code in the guided report perl -- in the export for the C4/Reports/Guided.pm git grep run_compound -- left over in export apply the patch look around and see the pieces are cleaned up. run koha qa test tools
Created attachment 74872 [details] [review] Bug 20663: Add some POD, so koha test tools don't complain
Created attachment 74925 [details] [review] Bug 20663: Remove dead code related to compound reports TEST PLAN --------- git grep "Create Compound Report" -- only one file git grep compound | grep 1 -- this is the only setting of the compound tt variable less koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt -- There is an TT IF statement for compound. -- In that statement it would trigger 'Save Compound' git grep save_compound -- only the template and the guided report perl git grep create_compound -- only triggered by the save code in the guided report perl -- in the export for the C4/Reports/Guided.pm git grep run_compound -- left over in export apply the patch look around and see the pieces are cleaned up. run koha qa test tools Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 74926 [details] [review] Bug 20663: Add some POD, so koha test tools don't complain Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Isn't this patch supposed to have the Signed-off status?
Correct, thx Frederic.
Created attachment 75055 [details] [review] Bug 20663: Remove dead code related to compound reports TEST PLAN --------- git grep "Create Compound Report" -- only one file git grep compound | grep 1 -- this is the only setting of the compound tt variable less koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt -- There is an TT IF statement for compound. -- In that statement it would trigger 'Save Compound' git grep save_compound -- only the template and the guided report perl git grep create_compound -- only triggered by the save code in the guided report perl -- in the export for the C4/Reports/Guided.pm git grep run_compound -- left over in export apply the patch look around and see the pieces are cleaned up. run koha qa test tools Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Created attachment 75056 [details] [review] Bug 20663: Add some POD, so koha test tools don't complain Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Dead since commit 68ce64a793b023164ac19a56602747945a1bdca1 Date: Mon Oct 29 13:19:58 2007 -0500 Bugfixing the template, and removing link to compound reports
Pushed to master for 18.05, thanks to everybody involved!