This patch will convert several acquisitions templates to use the Bootstrap grid: acqui/acqui-home.tt acqui/basketgroup.tt acqui/booksellers.tt acqui/edifactmsgs.tt acqui/edimsg.tt
Created attachment 74891 [details] [review] Bug 20667: Update two-column templates with Bootstrap grid: Acquisitions part 1 This patch modifies several acquisitions templates to use the Bootstrap grid instead of YUI. To test, apply the patch and view the following pages, confirming that they look correct at various browser widths: - Acquisitions -> Home page - Acquisitions -> Vendor search results - Acquisitions -> Vendor -> Basket groups -> Edit - Acquisitions -> EDIFACT messages -> View EDIFACT message
Hi Owen, On 'Edit basket group',label for "Baskets in this group:" is not on the grid. It's something we already have, I'm not sure your patch is supposed to fix it, but as the gap is bigger now, I prefer mention it. I didn't test for Edifact messages. Except these 2 points, display seemed good to me. I prefer not sign the patch to let someone else test it too.
Created attachment 74948 [details] [review] Bug 20667: Update two-column templates with Bootstrap grid: Acquisitions part 1 This patch modifies several acquisitions templates to use the Bootstrap grid instead of YUI. This patch also removes obsolete "text/javascript" attributes from <script> tags. To test, apply the patch and view the following pages, confirming that they look correct at various browser widths: - Acquisitions -> Home page - Acquisitions -> Vendor search results - Acquisitions -> Vendor -> Basket groups -> Edit - Acquisitions -> EDIFACT messages -> View EDIFACT message
(In reply to Séverine Queune from comment #2) > On 'Edit basket group',label for "Baskets in this group:" is not on the > grid. It's something we already have, I'm not sure your patch is supposed to > fix it My patch is not intended to fix it. There are other pending patches for this template and I want to limit what areas I modify.
Created attachment 74959 [details] [review] Bug 20667: Update two-column templates with Bootstrap grid: Acquisitions part 1 This patch modifies several acquisitions templates to use the Bootstrap grid instead of YUI. This patch also removes obsolete "text/javascript" attributes from <script> tags. To test, apply the patch and view the following pages, confirming that they look correct at various browser widths: - Acquisitions -> Home page - Acquisitions -> Vendor search results - Acquisitions -> Vendor -> Basket groups -> Edit - Acquisitions -> EDIFACT messages -> View EDIFACT message Signed-off-by: Dilan Johnpullé <dilan@calyx.net.au>
Created attachment 75748 [details] [review] Bug 20667: Update two-column templates with Bootstrap grid: Acquisitions part 1 This patch modifies several acquisitions templates to use the Bootstrap grid instead of YUI. This patch also removes obsolete "text/javascript" attributes from <script> tags. To test, apply the patch and view the following pages, confirming that they look correct at various browser widths: - Acquisitions -> Home page - Acquisitions -> Vendor search results - Acquisitions -> Vendor -> Basket groups -> Edit - Acquisitions -> EDIFACT messages -> View EDIFACT message Signed-off-by: Dilan Johnpullé <dilan@calyx.net.au> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Found a permission problem while testing this, filed and fixed on bug 20861.
Awesome work all! Pushed to master for 18.11
I love this update :) Enhancement, not backporting to 18.05.x series.