Bug 20736 - Update two-column templates with Bootstrap grid: Administration part 1
Summary: Update two-column templates with Bootstrap grid: Administration part 1
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords:
Depends on: 20668
Blocks: 20654 21295
  Show dependency treegraph
 
Reported: 2018-05-09 11:49 UTC by Owen Leonard
Modified: 2019-10-14 19:56 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 20736: Update two-column templates with Bootstrap grid, Administration part 1 (11.38 KB, patch)
2018-07-16 16:31 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 20736: Update two-column templates with Bootstrap grid, Administration part 1 (11.43 KB, patch)
2018-08-16 08:10 UTC, Claire Gravely
Details | Diff | Splinter Review
Bug 20736: Update two-column templates with Bootstrap grid, Administration part 1 (11.62 KB, patch)
2018-08-16 19:20 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2018-05-09 11:49:54 UTC
This patch will convert administration templates to use the Bootstrap grid:

 - aqbudgetperiods.tt
 - aqbudgets.tt
 - aqcontract.tt
 - aqplan.tt
 - audio_alerts.tt
 - authorised_values.tt
Comment 1 Owen Leonard 2018-07-16 16:31:19 UTC
Created attachment 77014 [details] [review]
Bug 20736: Update two-column templates with Bootstrap grid, Administration part 1

This patch modifies several acquisitions templates to use the Bootstrap
grid instead of YUI.

This patch also removes obsolete "text/javascript" attributes from
<script> tags in the modified templates.

To test, apply the patch and view the following pages, confirming that
they look correct at various browser widths:

 - Administration -> Budgets
   - View budgets list, view and edit budgets
   - View budget -> Planning -> Plan by months
 - Administration -> Funds
   - View funds list, view and edit funds
 - Acquisitions -> Vendor -> Contracts
   - View contracts list, view and edit contracts
 - Administration -> Audio alerts
 - Administration -> Authorized values
Comment 2 Claire Gravely 2018-08-16 08:10:50 UTC
Created attachment 77877 [details] [review]
Bug 20736: Update two-column templates with Bootstrap grid, Administration part 1

This patch modifies several acquisitions templates to use the Bootstrap
grid instead of YUI.

This patch also removes obsolete "text/javascript" attributes from
<script> tags in the modified templates.

To test, apply the patch and view the following pages, confirming that
they look correct at various browser widths:

 - Administration -> Budgets
   - View budgets list, view and edit budgets
   - View budget -> Planning -> Plan by months
 - Administration -> Funds
   - View funds list, view and edit funds
 - Acquisitions -> Vendor -> Contracts
   - View contracts list, view and edit contracts
 - Administration -> Audio alerts
 - Administration -> Authorized values

Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de>
Comment 3 Jonathan Druart 2018-08-16 19:20:54 UTC
Created attachment 77952 [details] [review]
Bug 20736: Update two-column templates with Bootstrap grid, Administration part 1

This patch modifies several acquisitions templates to use the Bootstrap
grid instead of YUI.

This patch also removes obsolete "text/javascript" attributes from
<script> tags in the modified templates.

To test, apply the patch and view the following pages, confirming that
they look correct at various browser widths:

 - Administration -> Budgets
   - View budgets list, view and edit budgets
   - View budget -> Planning -> Plan by months
 - Administration -> Funds
   - View funds list, view and edit funds
 - Acquisitions -> Vendor -> Contracts
   - View contracts list, view and edit contracts
 - Administration -> Audio alerts
 - Administration -> Authorized values

Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 4 Jonathan Druart 2018-08-16 19:21:42 UTC
Rebased on top of bug 13618.
Comment 5 Nick Clemens 2018-08-30 14:09:23 UTC
Awesome work all!

Pushed to master for 18.11
Comment 6 Martin Renvoize 2018-09-05 10:22:24 UTC
Enhancement, will not be backported to 18.5.x series.