Bug 20738 - Update two-column templates with Bootstrap grid: Administration part 2
Summary: Update two-column templates with Bootstrap grid: Administration part 2
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords:
Depends on: 20668
Blocks: 20654
  Show dependency treegraph
 
Reported: 2018-05-09 11:54 UTC by Owen Leonard
Modified: 2019-10-14 19:57 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 20738: Update two-column templates with Bootstrap grid, Administration part 2 (10.21 KB, patch)
2018-07-16 16:36 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 20738: Update two-column templates with Bootstrap grid, Administration part 2 (10.26 KB, patch)
2018-08-16 09:29 UTC, Claire Gravely
Details | Diff | Splinter Review
Bug 20738: Update two-column templates with Bootstrap grid, Administration part 2 (10.47 KB, patch)
2018-08-16 19:30 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2018-05-09 11:54:35 UTC
This patch will convert more administration templates to use the Bootstrap grid:

 - auth_subfields_structure.tt
 - auth_tag_structure.tt
 - authtypes.tt
 - biblio_framework.tt
 - branch_transfer_limits.tt
 - branches.tt
Comment 1 Owen Leonard 2018-07-16 16:36:34 UTC
Created attachment 77015 [details] [review]
Bug 20738: Update two-column templates with Bootstrap grid, Administration part 2

This patch modifies several acquisitions templates to use the Bootstrap
grid instead of YUI.

This patch also removes obsolete "text/javascript" attributes from
<script> tags in the modified templates.

To test, apply the patch and view the following pages, confirming that
they look correct at various browser widths:

 - Administration -> Authority types
   - View list of and edit authority types
     -> MARC tag structure for an authority type
        - View list of and edit tags
          -> Subfields
             - View list of and edit subfields
 - Administration -> MARC bibliographic framework
   - View list of and edit frameworks
 - Administration -> Libraries
   - View and edit libraries
 - Administration -> Library transfer limits
Comment 2 Claire Gravely 2018-08-16 09:29:18 UTC
Created attachment 77878 [details] [review]
Bug 20738: Update two-column templates with Bootstrap grid, Administration part 2

This patch modifies several acquisitions templates to use the Bootstrap
grid instead of YUI.

This patch also removes obsolete "text/javascript" attributes from
<script> tags in the modified templates.

To test, apply the patch and view the following pages, confirming that
they look correct at various browser widths:

 - Administration -> Authority types
   - View list of and edit authority types
     -> MARC tag structure for an authority type
        - View list of and edit tags
          -> Subfields
             - View list of and edit subfields
 - Administration -> MARC bibliographic framework
   - View list of and edit frameworks
 - Administration -> Libraries
   - View and edit libraries
 - Administration -> Library transfer limits

Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de>
Comment 3 Jonathan Druart 2018-08-16 19:30:27 UTC
Created attachment 77953 [details] [review]
Bug 20738: Update two-column templates with Bootstrap grid, Administration part 2

This patch modifies several acquisitions templates to use the Bootstrap
grid instead of YUI.

This patch also removes obsolete "text/javascript" attributes from
<script> tags in the modified templates.

To test, apply the patch and view the following pages, confirming that
they look correct at various browser widths:

 - Administration -> Authority types
   - View list of and edit authority types
     -> MARC tag structure for an authority type
        - View list of and edit tags
          -> Subfields
             - View list of and edit subfields
 - Administration -> MARC bibliographic framework
   - View list of and edit frameworks
 - Administration -> Libraries
   - View and edit libraries
 - Administration -> Library transfer limits

Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 4 Jonathan Druart 2018-08-16 19:31:07 UTC
Rebased on top of bug 13618.
Comment 5 Nick Clemens 2018-08-30 14:09:38 UTC
Awesome work all!

Pushed to master for 18.11
Comment 6 Martin Renvoize 2018-09-05 10:23:06 UTC
Enhancement, will not be backported to 18.05.x series.