The "Share list" button in the OPAC doesn't have an icon. It should be styled to fit in with the other list controls.
Created attachment 75312 [details] [review] Bug 20756: OPAC "Share list" button should be styled with an icon This patch adds a new "share" icon to the sprite image used to style controls in the OPAC. The "share list" links now have a "sharelist" class which is used to style the links with the new icon. Also changed: Fixed the page structure markup of opac-shareshelf.tt. To test you must have the OpacAllowSharingPrivateLists system preference enabled. - Log in to the OPAC and go to Lists -> Your lists. - Create one or more private lists if necessary. - In the table of your lists there should be a "Share" link with the new icon. - View one of these lists and confirm that the "Share" link at the top of the table of list items. - Click through to the share list page and confirm that the page looks correct.
Created attachment 75313 [details] [review] Bug 20756: Compiled CSS This patch contains the compiled CSS file
Created attachment 75498 [details] [review] Bug 20756: OPAC "Share list" button should be styled with an icon This patch adds a new "share" icon to the sprite image used to style controls in the OPAC. The "share list" links now have a "sharelist" class which is used to style the links with the new icon. Also changed: Fixed the page structure markup of opac-shareshelf.tt. To test you must have the OpacAllowSharingPrivateLists system preference enabled. - Log in to the OPAC and go to Lists -> Your lists. - Create one or more private lists if necessary. - In the table of your lists there should be a "Share" link with the new icon. - View one of these lists and confirm that the "Share" link at the top of the table of list items. - Click through to the share list page and confirm that the page looks correct. Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr>
Created attachment 75499 [details] [review] Bug 20756: Compiled CSS This patch contains the compiled CSS file Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr>
Seems good to me on all pages. Thanks Owen !
Created attachment 75559 [details] [review] Bug 20756: OPAC "Share list" button should be styled with an icon This patch adds a new "share" icon to the sprite image used to style controls in the OPAC. The "share list" links now have a "sharelist" class which is used to style the links with the new icon. Also changed: Fixed the page structure markup of opac-shareshelf.tt. To test you must have the OpacAllowSharingPrivateLists system preference enabled. - Log in to the OPAC and go to Lists -> Your lists. - Create one or more private lists if necessary. - In the table of your lists there should be a "Share" link with the new icon. - View one of these lists and confirm that the "Share" link at the top of the table of list items. - Click through to the share list page and confirm that the page looks correct. Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Created attachment 75560 [details] [review] Bug 20756: Compiled CSS This patch contains the compiled CSS file Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Pushed to master for 18.11, awesome work all!
This patch has been pushed to 18.05.x and will be in 18.05.01 A minor cosmetic improvement that shouldn't confuse existing users, backported, thanks all.
Not backported to 17.11.x. I prefer not to change the compiled CSS.