Bug 20779 - Style refresh for patron detail page
Summary: Style refresh for patron detail page
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: master
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords:
Depends on: 20520
Blocks: 23573 20809 21209
  Show dependency treegraph
 
Reported: 2018-05-18 13:45 UTC by Owen Leonard
Modified: 2020-06-04 20:32 UTC (History)
7 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Screenshot of the patron detail page before the patch (108.02 KB, image/png)
2018-05-18 14:05 UTC, Owen Leonard
Details
Screenshot of the patron detail page after the patch (111.79 KB, image/png)
2018-05-18 14:05 UTC, Owen Leonard
Details
Bug 20779 - Style refresh for patron detail page (34.92 KB, patch)
2018-05-18 14:18 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 20779: Style refresh for patron detail page (34.97 KB, patch)
2018-05-23 14:36 UTC, Mark Tompsett
Details | Diff | Splinter Review
Screenshot highlighting markup structure. (6.92 KB, image/png)
2018-05-29 12:13 UTC, Owen Leonard
Details
Screenshot showing buttons in line with headings (145.82 KB, image/png)
2018-05-29 15:42 UTC, Owen Leonard
Details
More polished version of buttons in line with headings (123.76 KB, image/png)
2018-06-04 16:08 UTC, Owen Leonard
Details
Bug 20779: Style refresh for patron detail page (38.51 KB, patch)
2018-06-06 12:47 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 20779: Style refresh for patron detail page (38.57 KB, patch)
2018-07-15 19:02 UTC, Biblibre Sandboxes
Details | Diff | Splinter Review
Bug 20779: Style refresh for patron detail page (38.62 KB, patch)
2018-07-18 21:02 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2018-05-18 13:45:52 UTC
I have some style updates for the patron detail page (moremember.tt) which I think will make the page more readable.
Comment 1 Owen Leonard 2018-05-18 14:05:35 UTC
Created attachment 75434 [details]
Screenshot of the patron detail page before the patch
Comment 2 Owen Leonard 2018-05-18 14:05:51 UTC Comment hidden (obsolete)
Comment 3 Owen Leonard 2018-05-18 14:18:47 UTC Comment hidden (obsolete)
Comment 4 Mark Tompsett 2018-05-23 14:36:07 UTC Comment hidden (obsolete)
Comment 5 Jonathan Druart 2018-05-28 20:39:50 UTC
That's a lot of buttons!

Would not it be better to move the "edit" button on the same line as the header block ("Library use", "Alternate address", etc.)?
Comment 6 Katrin Fischer 2018-05-28 20:43:30 UTC
I like Jonathan's idea I think.
Also (if not done already) it would be nice if in the future it would be easier to hide the edit buttons together with the sections. Unwanted fields does not apply to this screen and the buttons always have to be hidden separately.
Comment 7 Owen Leonard 2018-05-29 12:12:17 UTC
(In reply to Jonathan Druart from comment #5)
> That's a lot of buttons!

I've gotten feedback from librarians that the edit links were not visible enough. It's clearly an opinion, so we'll need to use our best judgement.

> Would not it be better to move the "edit" button on the same line as the
> header block ("Library use", "Alternate address", etc.)?

The way I have it the edit button appears on the same line as the header if there is no content in the section, and at the bottom if there is. This is my preference, but I'm happy to be outvoted.
Comment 8 Owen Leonard 2018-05-29 12:13:24 UTC
Created attachment 75628 [details]
Screenshot highlighting markup structure.

> Also (if not done already) it would be nice if in the future it would be
> easier to hide the edit buttons together with the sections.

I think I've already done what you're talking about.
Comment 9 Jonathan Druart 2018-05-29 14:09:10 UTC
Maybe we should ask on the list?
Comment 10 Owen Leonard 2018-05-29 15:42:29 UTC Comment hidden (obsolete)
Comment 11 Josef Moravec 2018-05-30 07:19:43 UTC
(In reply to Owen Leonard from comment #10)
> Created attachment 75638 [details]
> Screenshot showing buttons in line with headings
> 
> Here is a screenshot of what it might look like with the edit buttons inline
> with headings.

It does make sense to have buttons in sections headings, but then, I would like to see more space before headings, what do you think?
Comment 12 Owen Leonard 2018-06-04 16:08:42 UTC
Created attachment 75780 [details]
More polished version of buttons in line with headings
Comment 13 Josef Moravec 2018-06-05 05:33:08 UTC
(In reply to Owen Leonard from comment #12)
> Created attachment 75780 [details]
> More polished version of buttons in line with headings

That looks great!
Comment 14 Owen Leonard 2018-06-06 12:47:29 UTC
Created attachment 75855 [details] [review]
Bug 20779: Style refresh for patron detail page

This patch makes style and markup changes to the patron detail page
template in order to make the display of information somewhat more
compact and to increase the visibility of the edit controls.

To test you should enable the patronimages system preference. Apply the
patch and view the detail page for a patron.

- Check that the page looks correct and that sections like "Alternate
  address" and "Alternative contact" are empty when there is no data.
- Check that the "Manage patron image" tool works correctly.
Comment 15 Biblibre Sandboxes 2018-07-15 19:02:13 UTC
Patch tested with a sandbox, by Cab Vinton <director@plaistowlibrary.com>
Comment 16 Biblibre Sandboxes 2018-07-15 19:02:51 UTC
Created attachment 76968 [details] [review]
Bug 20779: Style refresh for patron detail page

This patch makes style and markup changes to the patron detail page
template in order to make the display of information somewhat more
compact and to increase the visibility of the edit controls.

To test you should enable the patronimages system preference. Apply the
patch and view the detail page for a patron.

- Check that the page looks correct and that sections like "Alternate
  address" and "Alternative contact" are empty when there is no data.
- Check that the "Manage patron image" tool works correctly.

Signed-off-by: Cab Vinton <director@plaistowlibrary.com>
Comment 17 Katrin Fischer 2018-07-18 21:02:38 UTC
Created attachment 77092 [details] [review]
Bug 20779: Style refresh for patron detail page

This patch makes style and markup changes to the patron detail page
template in order to make the display of information somewhat more
compact and to increase the visibility of the edit controls.

To test you should enable the patronimages system preference. Apply the
patch and view the detail page for a patron.

- Check that the page looks correct and that sections like "Alternate
  address" and "Alternative contact" are empty when there is no data.
- Check that the "Manage patron image" tool works correctly.

Signed-off-by: Cab Vinton <director@plaistowlibrary.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 18 Nick Clemens 2018-08-09 12:25:01 UTC
Awesome work all!

Pushed to master for 18.11
Comment 19 Martin Renvoize 2018-08-10 08:17:47 UTC
Enhancement, will not be backported to 18.05.x series.