If you change the value of MarcFieldDocURL, and you catalog using the advanced editor, the help still points to Library of Congress. To reproduce : 1) Leave MarcFieldDocURL at its default value (empty) 2) Enable EnableAdvancedCatalogingEditor 2) Go to the cataloguing module 3) Click on 'New record' and choose a framework 3.5) (If you are not in the basic editor, click on 'Settings' and choose 'Switch to basic editor') 4) Click on the question mark (?) next to any MARC field 5) Note that the default goes to www.loc.gov 6) Click on 'Settings' 7) Choose 'Switch to advanced editor' (click OK on the confirmation) 8) Put your cursor next to a MARC field 9) At the bottom of the page, click on the question mark ([?]) 10) Note that the default goes to www.loc.gov 11) Go to Administration > Global System Preferences 12) Search for EnableAdvancedCatalogingEditor and enter http://www.marc21.ca/MaJ/BIB/B{FIELD}.pdf in the box 13) Save the system preferences 14) Redo steps 2 to 4 15) Note that the help goes to www.marc21.ca 16) Redo steps 6 to 9 17) Note that the help still goes to www.loc.gov
Created attachment 78110 [details] [review] Bug 20785: Advanced Editor does not honor MarcFieldDocURL The advanced MARC editor, Rancor, doesn't obey MarcFieldDocURL. Make it do so. Test plan: 1) Enable EnableAdvancedCatalogingEditor 2) Set MarcFieldDocURL to eg. http://{MARC}.example.com/{LANG}/{FIELD} 3) Go to Cataloging -> Advanced editor 4) Go to any field and press Ctrl-H 5) Marc field documentation on www.loc.gov or ifla.org should open 6) Apply patch 7) Repeat 3 and 4. The Marc field docs should open on the URL you set
Created attachment 79469 [details] [review] Bug 20785: Advanced Editor does not honor MarcFieldDocURL The advanced MARC editor, Rancor, doesn't obey MarcFieldDocURL. Make it do so. Test plan: 1) Enable EnableAdvancedCatalogingEditor 2) Set MarcFieldDocURL to eg. http://{MARC}.example.com/{LANG}/{FIELD} 3) Go to Cataloging -> Advanced editor 4) Go to any field and press Ctrl-H 5) Marc field documentation on www.loc.gov or ifla.org should open 6) Apply patch 7) Repeat 3 and 4. The Marc field docs should open on the URL you set Signed-off-by: Pasi Kallinen <pasi.kallinen@joensuu.fi> Signed-off-by: Michal Denar <black23@gmail.com>
Created attachment 79479 [details] [review] Bug 20785: Advanced Editor does not honor MarcFieldDocURL The advanced MARC editor, Rancor, doesn't obey MarcFieldDocURL. Make it do so. Test plan: 1) Enable EnableAdvancedCatalogingEditor 2) Set MarcFieldDocURL to eg. http://{MARC}.example.com/{LANG}/{FIELD} 3) Go to Cataloging -> Advanced editor 4) Go to any field and press Ctrl-H 5) Marc field documentation on www.loc.gov or ifla.org should open 6) Apply patch 7) Repeat 3 and 4. The Marc field docs should open on the URL you set Signed-off-by: Pasi Kallinen <pasi.kallinen@joensuu.fi> Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Awesome work all! Pushed to master for 18.11
Pushed to 18.05.x for 18.05.05
Pushed to 17.11.x for 17.11.11