Because of code missing from templates and Perl scripts, the "Update child to adult patron" process is not working correctly on several pages: Broken altogether: - Batch check out If multiple adult patron categories are configured, the "update child" process should trigger a pop-up where the user can choose a category. On these pages the pop-up isn't being triggered, and the process results in an error. - Notices - Statistics - Files - Housebound
The latter issue is also present with the patron deletion confirmation page (deletemem.pl).
Created attachment 75487 [details] [review] Bug 20805: Update child to adult patron process broken on several patron-related pages This patch fixes a problem with several patron-related pages, where the "Update child to adult patron" menu item doesn't work. With some pages, the right category information wasn't being passed from the script to the template. With some, the right JavaScript variable weren't being passed from the template to the included JavaScript file. To test, apply the patch locate some patrons with "child" type patron categories. With each patron, go to one of the following pages and test the "update child" process in the toolbar's "More" menu. - Circulation -> - Batch check out - Notices - Statistics - Files - Housebound - Delete (test from the deletion confirmation screen). All test should be performed on a system with multiple adult patron categories configured AND on a system with only a single adult patron category.
Created attachment 76772 [details] [review] Bug 20805: Update child to adult patron process broken on several patron-related pages This patch fixes a problem with several patron-related pages, where the "Update child to adult patron" menu item doesn't work. With some pages, the right category information wasn't being passed from the script to the template. With some, the right JavaScript variable weren't being passed from the template to the included JavaScript file. To test, apply the patch locate some patrons with "child" type patron categories. With each patron, go to one of the following pages and test the "update child" process in the toolbar's "More" menu. - Circulation -> - Batch check out - Notices - Statistics - Files - Housebound - Delete (test from the deletion confirmation screen). All test should be performed on a system with multiple adult patron categories configured AND on a system with only a single adult patron category. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 76936 [details] [review] Bug 20805: Update child to adult patron process broken on several patron-related pages This patch fixes a problem with several patron-related pages, where the "Update child to adult patron" menu item doesn't work. With some pages, the right category information wasn't being passed from the script to the template. With some, the right JavaScript variable weren't being passed from the template to the included JavaScript file. To test, apply the patch locate some patrons with "child" type patron categories. With each patron, go to one of the following pages and test the "update child" process in the toolbar's "More" menu. - Circulation -> - Batch check out - Notices - Statistics - Files - Housebound - Delete (test from the deletion confirmation screen). All test should be performed on a system with multiple adult patron categories configured AND on a system with only a single adult patron category. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Awesome work all! Pushed to master for 18.11
Pushed to 18.05.x for 18.05.02
Reading the diff it seems that the Asset.js and the <script> are inverted, Asset.js must be after (in members/deletemem.tt)
Depends on Bug 19641 that added members-menu.js
Depends on Bug 19641 not in 17.11.x