Printing HOLD_SLIP from the Hold found modal can't find the template. In "returns.tt" the print action is sent "patron.borrowernumber", but the print-slip template parameters in "returns.pl" only include "borrowernumber" and "biblionumber", not "patron".
Caused by commit ab47e46ea0ade643b308a8b00708d57995c57050 Bug 18789: Pass a Koha::Patron object from returns.pl
Created attachment 75598 [details] [review] Bug 20822: (bug 18789 follow-up) Fix HOLD_SLIP Caused by commit ab47e46ea0ade643b308a8b00708d57995c57050 Bug 18789: Pass a Koha::Patron object from returns.pl circ/returns.pl does not send a $patron Koha::Patron object to the template in case print_slip is set Test plan: Confirm a hold and print the slip
Test plan: - Place a hold on an item or record - Return an item to fill the hold - Check the item in - Pick "print and confirm" - Instead of the notice, an error will display in the preview pop-up
Created attachment 75610 [details] [review] Bug 20822: (bug 18789 follow-up) Fix HOLD_SLIP Caused by commit ab47e46ea0ade643b308a8b00708d57995c57050 Bug 18789: Pass a Koha::Patron object from returns.pl circ/returns.pl does not send a $patron Koha::Patron object to the template in case print_slip is set Test plan: Confirm a hold and print the slip Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 75612 [details] [review] Bug 20822: (bug 18789 follow-up) Fix HOLD_SLIP Caused by commit ab47e46ea0ade643b308a8b00708d57995c57050 Bug 18789: Pass a Koha::Patron object from returns.pl circ/returns.pl does not send a $patron Koha::Patron object to the template in case print_slip is set Test plan: Confirm a hold and print the slip Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Pushed to master for 18.11. Awesome work all, thank you.
This patch has been pushed to 18.05.x, will be in 18.05.01
Depends on Bug 18789 not in 17.11.x