Created attachment 75575 [details] Message in browser When I try to issue an instance and enter a barcode, the program displays the following message: Software error: The method is not covered by tests!
Created attachment 75576 [details] barcode input
Can you please check your item has a valid itemtype, homebranch and what is set in the not for loan status? What is the exact version of Koha you are using?
18.05.00.000
Created attachment 75578 [details] 18.05.00.000
This happened when the program was updated to the latest version.
Can you also share a screenshot of your item please?
Created attachment 75579 [details] item
Created attachment 75580 [details] item
In version 17.11, the release works, but the return does not work, and in version 18.05 the output does not work, but the return works.
And literally three days ago everything worked. But when the latest updates came one by one, everything broke.
Caused by commit 6183c0e6a910663fec02bdba66d05f173310f562 Bug 19943: Koha::Biblio - Replace GetBiblioItemData with Koha::Biblio->biblioitem It happens when item types are defined at biblio level.
Created attachment 75591 [details] [review] Bug 20825: Add regression tests
Created attachment 75592 [details] [review] Bug 20825: (bug 19943 follow-up) call notforloan on itemtype instead of biblioitem On bug 19943: - elsif ($biblioitem->{'notforloan'} == 1){ + elsif ($biblioitem->notforloan == 1){ The biblioitems table does not contain a notforloan column, this comes from the item type. This bug only appears when item type is defined at biblio level (item-level_itypes=0) Test plan: Set item-level_itypes = biblio Check an item out Without this patch it explodes with "The method notforloan is not covered by tests!"
Created attachment 75595 [details] [review] Bug 20825: Add regression tests Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Created attachment 75596 [details] [review] Bug 20825: (bug 19943 follow-up) call notforloan on itemtype instead of biblioitem On bug 19943: - elsif ($biblioitem->{'notforloan'} == 1){ + elsif ($biblioitem->notforloan == 1){ The biblioitems table does not contain a notforloan column, this comes from the item type. This bug only appears when item type is defined at biblio level (item-level_itypes=0) Test plan: Set item-level_itypes = biblio Check an item out Without this patch it explodes with "The method notforloan is not covered by tests!" Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> I reproduced the error condition and verified the tests failed without this patch. After this patch is applied, tests pass and checkout succeeds.
Created attachment 75605 [details] [review] Bug 20825: Add regression tests Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 75606 [details] [review] Bug 20825: (bug 19943 follow-up) call notforloan on itemtype instead of biblioitem On bug 19943: - elsif ($biblioitem->{'notforloan'} == 1){ + elsif ($biblioitem->notforloan == 1){ The biblioitems table does not contain a notforloan column, this comes from the item type. This bug only appears when item type is defined at biblio level (item-level_itypes=0) Test plan: Set item-level_itypes = biblio Check an item out Without this patch it explodes with "The method notforloan is not covered by tests!" Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> I reproduced the error condition and verified the tests failed without this patch. After this patch is applied, tests pass and checkout succeeds. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 75607 [details] [review] Bug 20825: Add regression tests Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 75608 [details] [review] Bug 20825: (bug 19943 follow-up) call notforloan on itemtype instead of biblioitem On bug 19943: - elsif ($biblioitem->{'notforloan'} == 1){ + elsif ($biblioitem->notforloan == 1){ The biblioitems table does not contain a notforloan column, this comes from the item type. This bug only appears when item type is defined at biblio level (item-level_itypes=0) Test plan: Set item-level_itypes = biblio Check an item out Without this patch it explodes with "The method notforloan is not covered by tests!" Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> I reproduced the error condition and verified the tests failed without this patch. After this patch is applied, tests pass and checkout succeeds. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Thanks, it works.
Pushed to master for 18.11. Awesome work all, thank you.
Created attachment 75639 [details] [review] Bug 20825: (QA follow-up) set biblioitemnumber with correct value Both biblionumber and biblioitemnumber for item were set to biblionumber, when they don't line up tests fail Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
This patch has been pushed to 18.05.x, will be in 18.05.01
Depends on Bug 19943 not in 17.11.x