To reproduce: Have an overdue fine linked with specific item currently checked out to you Do not have any unpaid rental fees Go to your profile in opac : opac-user.pl -> the page crash and you can see in log: Can't call method "get_column" on an undefined value at /usr/share/koha/opac/cgi-bin/opac/opac-user.pl line 217
Created attachment 75624 [details] [review] Bug 20832: Fix opac user profile page when there is overdue fine and no rental charge Test plan: 0) Do not apply the patch 1) Have an overdue fine linked with specific item currently checked out to your patron 2) Do not have any unpaid rental fees 3) Go to this patron profile in opac - page opac-user.pl 4) The page crashes with "Can't call method "get_column" on an undefined value at /usr/share/koha/opac/cgi-bin/opac/opac-user.pl line 217" in log 5) Apply the patch 6) Restart plack 7) The page should working and show the right amounts for fines
Created attachment 75945 [details] [review] Bug 20832: Fix opac user profile page when there is overdue fine and no rental charge Test plan: 0) Do not apply the patch 1) Have an overdue fine linked with specific item currently checked out to your patron 2) Do not have any unpaid rental fees 3) Go to this patron profile in opac - page opac-user.pl 4) The page crashes with "Can't call method "get_column" on an undefined value at /usr/share/koha/opac/cgi-bin/opac/opac-user.pl line 217" in log 5) Apply the patch 6) Restart plack 7) The page should working and show the right amounts for fines Signed-off-by: Andrew Isherwood <andrew.isherwood@ptfs-europe.com>
Silly copy/paste error caused by commit 51aa6db46c604aa202a3d8f8e5028557480efbd5 Bug 12001: Move GetMemberAccountRecords to the Koha namespace
Created attachment 75969 [details] [review] Bug 20832: Fix opac user profile page when there is overdue fine and no rental charge Test plan: 0) Do not apply the patch 1) Have an overdue fine linked with specific item currently checked out to your patron 2) Do not have any unpaid rental fees 3) Go to this patron profile in opac - page opac-user.pl 4) The page crashes with "Can't call method "get_column" on an undefined value at /usr/share/koha/opac/cgi-bin/opac/opac-user.pl line 217" in log 5) Apply the patch 6) Restart plack 7) The page should working and show the right amounts for fines Signed-off-by: Andrew Isherwood <andrew.isherwood@ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
*** Bug 20914 has been marked as a duplicate of this bug. ***
Awesome work all! Pushed to master for 18.11
Pushed to 18.05.x for 18.05.01
Depends on Bug 12001 not in 17.11.x
Even with Bug 12001 patch for 17.11.x this patch is not for 17.11.x