Bug 20862 - Error on cart when containing a deleted record
Summary: Error on cart when containing a deleted record
Status: CLOSED INVALID
Alias: None
Product: Koha
Classification: Unclassified
Component: Searching (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor (vote)
Assignee: Bugs List
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-06-03 09:07 UTC by Katrin Fischer
Modified: 2019-10-14 19:57 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2018-06-03 09:07:49 UTC
Seen on intranet:

When the cart contains the biblionumber of a deleted record, on opening the cart an Internal server error will be shown.

This can happen, when your index is not up to date and maybe when deleting a record after adding it in some circumstances. We should handle it more gracefully.
Comment 1 Jonathan Druart 2018-06-04 15:01:01 UTC
I do not recreate, did you test on master?
What is the exact error message?
Comment 2 Katrin Fischer 2018-06-04 15:30:32 UTC
I will try to recreate it. It was a problem with Elasticsearch not updating automatically I think and then the deleted record remained in search results when I added them.
Comment 3 Katrin Fischer 2018-06-04 19:01:12 UTC
Long error, the record listed doesn't exist in my database anymore:

 problem with :392 : Field 942 must have at least one subfield at /usr/share/perl5/MARC/File/XML.pm line 481.
 
<?xml version="1.0" encoding="UTF-8"?>
<record
    xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
    xsi:schemaLocation="http://www.loc.gov/MARC21/slim http://www.loc.gov/standards/marcxml/schema/MARC21slim.xsd"
    xmlns="http://www.loc.gov/MARC21/slim">

  <leader>01023nam a2200301   4500</leader>
  <controlfield tag="001">DAW28259733</controlfield>
  <controlfield tag="008">140801s2011    enk           001 0 eng |</controlfield>
  <datafield tag="020" ind1=" " ind2=" ">
    <subfield code="a">0198709463 (paperback) </subfield>
  </datafield>
  <datafield tag="020" ind1=" " ind2=" ">
    <subfield code="a">9780198709466 (paperback) </subfield>
  </datafield>
  <datafield tag="040" ind1=" " ind2=" ">
    <subfield code="d">DAWSON</subfield>
    <subfield code="e">rda</subfield>
  </datafield>
  <datafield tag="050" ind1="0" ind2="4">
    <subfield code="a">KD2079</subfield>
    <subfield code="b">.C66 2011</subfield>
  </datafield>
  <datafield tag="082" ind1="0" ind2="4">
    <subfield code="a">346.42066</subfield>
    <subfield code="2">23</subfield>
  </datafield>
  <datafield tag="245" ind1="0" ind2="0">
    <subfield code="a">Blackstone's statutes on company law 2014-2015 /</subfield>
    <subfield code="c">edited by Derek French.</subfield>
  </datafield>
  <datafield tag="250" ind1=" " ind2=" ">
    <subfield code="a">18 edition.</subfield>
  </datafield>
  <datafield tag="264" ind1=" " ind2="1">
    <subfield code="a">Oxford :</subfield>
    <subfield code="b">Oxford University Press,</subfield>
    <subfield code="c">2014.</subfield>
  </datafield>
  <datafield tag="300" ind1=" " ind2=" ">
    <subfield code="a">750 pages ;</subfield>
    <subfield code="c">25 cm.</subfield>
  </datafield>
  <datafield tag="336" ind1=" " ind2=" ">
    <subfield code="a">text</subfield>
    <subfield code="2">rdacontent</subfield>
  </datafield>
  <datafield tag="337" ind1=" " ind2=" ">
    <subfield code="a">unmediated</subfield>
    <subfield code="2">rdamedia</subfield>
  </datafield>
  <datafield tag="338" ind1=" " ind2=" ">
    <subfield code="a">volume</subfield>
    <subfield code="2">rdacarrier</subfield>
  </datafield>
  <datafield tag="490" ind1="1" ind2=" ">
    <subfield code="a">Blackstone's statutes series</subfield>
  </datafield>
  <datafield tag="500" ind1=" " ind2=" ">
    <subfield code="a">Includes index.</subfield>
  </datafield>
  <datafield tag="650" ind1=" " ind2="0">
    <subfield code="a">Corporation law</subfield>
    <subfield code="z">England.</subfield>
  </datafield>
  <datafield tag="650" ind1=" " ind2="0">
    <subfield code="a">Corporation law</subfield>
    <subfield code="z">Wales.</subfield>
  </datafield>
  <datafield tag="700" ind1="1" ind2=" ">
    <subfield code="a">French, Derek,</subfield>
    <subfield code="e">editor of compilation.</subfield>
  </datafield>
  <datafield tag="830" ind1=" " ind2="0">
    <subfield code="a">Blackstones statutes.</subfield>
  </datafield>
  <datafield tag="999" ind1=" " ind2=" ">
    <subfield code="c">392</subfield>
    <subfield code="d">392</subfield>
  </datafield>
  <datafield tag="942" ind1=" " ind2=" ">
  </datafield>
  <datafield tag="773" ind1="0" ind2=" ">
    <subfield code="0">69</subfield>
    <subfield code="9">150</subfield>
    <subfield code="a">Shetter, William Z.</subfield>
    <subfield code="b">8th ed.</subfield>
    <subfield code="d">London : Routledge, 2002.</subfield>
    <subfield code="o">39999000002850</subfield>
    <subfield code="t">Dutch :</subfield>
    <subfield code="w">(OSt)3555020</subfield>
    <subfield code="x"></subfield>
    <subfield code="z">0415235014 :</subfield>
  </datafield>
</record>
GetRecordValue called with undefined record at /home/vagrant/kohaclone/basket/basket.pl line 69.
GetMarcNotes called on undefined record at /home/vagrant/kohaclone/basket/basket.pl line 70.
GetMarcAuthors called on undefined record at /home/vagrant/kohaclone/basket/basket.pl line 71.
GetMarcSubjects called on undefined record at /home/vagrant/kohaclone/basket/basket.pl line 72.
GetMarcSeries called on undefined record at /home/vagrant/kohaclone/basket/basket.pl line 73.
GetMarcUrls called on undefined record at /home/vagrant/kohaclone/basket/basket.pl line 74.
Can't use an undefined value as an ARRAY reference at /home/vagrant/kohaclone/basket/basket.pl line 78.
Comment 4 Katrin Fischer 2018-06-04 19:17:02 UTC
It looks like a malformed record was the cause, marking invalid. Thx for helping me figure it out!