Bug 20880 - Upgraded 17.11 to 18.05: Malformed Bootstrap Theme Filenames
Summary: Upgraded 17.11 to 18.05: Malformed Bootstrap Theme Filenames
Status: CLOSED INVALID
Alias: None
Product: Koha
Classification: Unclassified
Component: OPAC (show other bugs)
Version: 18.05
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords:
Depends on: 12904
Blocks:
  Show dependency treegraph
 
Reported: 2018-06-04 22:02 UTC by Christian McDonald
Modified: 2019-10-14 19:57 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Christian McDonald 2018-06-04 22:02:51 UTC
My 18.05 (from 17.11) OPAC is trying to download files like this:

'https://library.mydomain.com/opac-tmpl/bootstrap/lib/modernizr.min_18.0500000.js'

These files do not exist.

it should be:

'https://library.graa.com/opac-tmpl/bootstrap/lib/modernizr.min.js'
Comment 1 Christian McDonald 2018-06-04 22:16:37 UTC
https://library.mydomain.com/opac-tmpl/bootstrap/lib/modernizr.min.js

So much for obfuscation lol
Comment 2 Christian McDonald 2018-06-04 23:33:23 UTC
For some reason, my 'apache-shared-opac.conf' was missing the following lines:

RewriteRule ^(.*)_[0-9][0-9]\.[0-9][0-9][0-9][0-9][0-9][0-9][0-9].js$ $1.js [L]
RewriteRule ^(.*)_[0-9][0-9]\.[0-9][0-9][0-9][0-9][0-9][0-9][0-9].css$ $1.css [L]

Adding them fixed this problem.
Comment 3 Katrin Fischer 2018-06-05 05:24:21 UTC
Hi Christian, this is not bug, but a feature. It removes the need to clean your cache after updating, that when forgotten could lead to a lot of strange issues.

See here: bug 12904

And from the release notes:

For non-package installations, the following rewrite rules will need to be added to the apache config file:
RewriteRule ^(.)[0-9][0-9].[0-9][0-9][0-9][0-9][0-9][0-9][0-9].js$ $1.js [L]
RewriteRule ^(.)[0-9][0-9].[0-9][0-9][0-9][0-9][0-9][0-9][0-9].css$ $1.css [L]
Comment 4 Christian McDonald 2018-06-05 16:10:29 UTC
What's confusing to me is that my installation IS a packaged installation (Debian using the stable repository).
Comment 5 Katrin Fischer 2018-06-05 17:28:41 UTC
Ok, out of my depth then. Should we reopen?
Comment 6 Jonathan Druart 2018-06-05 17:42:59 UTC
(In reply to Christian McDonald from comment #4)
> What's confusing to me is that my installation IS a packaged installation
> (Debian using the stable repository).

When you upgraded, did apt ask you something about this file?
If you manually edited the file before the upgrade, apt asks you what you want to do with the file: pick the one from the maintainer, keep yours, etc.
If you selected something else than picking the file provided by the package it is expected that these lines are missing.